On Sun, 01 Dec 2019 12:30:00 +1100, Stuart Prescott wrote: > Checking that the file mode is exactly 0755 when all that is actually desired > is that the file be executable seems wrong. Ack, and getting this message for each and every package I build gets a bit boring ("my" debian/rules are 775 as well). > checks/debian/rules.pm: > > # Check if debian/rules is marked as executable. > $self->tag('debian-rules-not-executable') > unless $rules->operm == 0755 or $rules->is_symlink; > > perhaps a better test would be (my perl is rather rusty): > > $rules->operm & 0111 I also note that lib/Lintian/Path.pm has sub is_executable { return $_[0]->_any_bit_in_operm(0111); } which might be reusable for this test. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: David Bowie: Young Americans
Attachment:
signature.asc
Description: Digital Signature