Bug#945869: lintian: false positive for debian-rules-not-executable
- To: 945869@bugs.debian.org
- Subject: Bug#945869: lintian: false positive for debian-rules-not-executable
- From: Stuart Prescott <stuart@debian.org>
- Date: Sun, 01 Dec 2019 12:30:00 +1100
- Message-id: <[🔎] 1606878.RDNRFE6ff0@simurgh>
- Reply-to: Stuart Prescott <stuart@debian.org>, 945869@bugs.debian.org
- In-reply-to: <20191130103253.GA1431@argenau.bebt.de>
- References: <20191130054418.GA14097@argenau.bebt.de> <CAFHYt54=CcY9aODU8Vmm2QKNWRhb_R0Q-nMyiQqgUGMved4ZYA@mail.gmail.com> <20191130103253.GA1431@argenau.bebt.de> <20191130054418.GA14097@argenau.bebt.de>
Checking that the file mode is exactly 0755 when all that is actually desired
is that the file be executable seems wrong.
checks/debian/rules.pm:
# Check if debian/rules is marked as executable.
$self->tag('debian-rules-not-executable')
unless $rules->operm == 0755 or $rules->is_symlink;
perhaps a better test would be (my perl is rather rusty):
$rules->operm & 0111
cheers
Stuart
--
Stuart Prescott http://www.nanonanonano.net/ stuart@nanonanonano.net
Debian Developer http://www.debian.org/ stuart@debian.org
GPG fingerprint 90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7
Reply to: