[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#943684: marked as done (lintian: Refine ‘override_dh_auto_test’ check to trigger only when different command)

Your message dated Thu, 31 Oct 2019 18:20:19 +0000
with message-id <E1iQF3T-0008jI-Lw@fasolo.debian.org>
and subject line Bug#943684: fixed in lintian 2.32.0
has caused the Debian Bug report #943684,
regarding lintian: Refine ‘override_dh_auto_test’ check to trigger only when different command
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
943684: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943684
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.15.0
Severity: normal

The check ‘override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS’
triggers incorrectly when the ‘override_dh_auto_test’ target merely
invokes ‘dh_auto_test’ with different options.

=====
$ grep '^override_dh_auto_test:' --after-context 3 debian/rules
override_dh_auto_test:
        dh_auto_test --buildsystem=makefile

$ lintian
[…]
I: python-daemon source: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS (line 25)
[…]
=====

The manual page ‘dh(1)’ explains of “override targets” that:

    The override target can then run the command with additional
    options, or run entirely different commands instead.

The above usage is a normal use of override target to change the
command-line option with which ‘dh_auto_test’ is invoked. This does
not need to be further wrapped with a ‘DEB_BUILD_OPTIONS’ test,
because that is done when ‘dh_auto_test’ runs.

Please change Lintian so that this check is done only when the
‘override_dh_auto_test’ target contains commands *other than* a
‘dh_auto_test’ command. The logic could be:

* If this is an ‘override_dh_auto_test’ target:
  * If there is exactly one command in the rule:
    * If the command name is ‘dh_auto_test’:
      * Do not inspect whether ‘DEB_BUILD_OPTIONS’ is tested.

  * Otherwise (different command; or multiple commands):
    * Inspect whether ‘DEB_BUILD_OPTIONS’ is tested. If not:
      * Emit ‘override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS’.


-- System Information:
Debian Release: 10.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-6-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_AU.UTF-8), LANGUAGE=en_AU.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_AU.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils                       2.31.1-16
ii  bzip2                          1.0.6-9.2~deb10u1
ii  diffstat                       1.62-1
ii  dpkg                           1.19.7
ii  dpkg-dev                       1.19.7
ii  file                           1:5.35-4+deb10u1
ii  gettext                        0.19.8.1-9
ii  gpg                            2.2.12-1+deb10u1
ii  intltool-debian                0.35.0+20060710.5
ii  libapt-pkg-perl                0.1.34+b1
ii  libarchive-zip-perl            1.64-1
ii  libcapture-tiny-perl           0.48-1
ii  libcgi-pm-perl                 4.40-1
ii  libclass-accessor-perl         0.51-1
ii  libclone-perl                  0.41-1+b1
ii  libdpkg-perl                   1.19.7
ii  libemail-valid-perl            1.202-1
ii  libfile-basedir-perl           0.08-1
ii  libio-async-perl               0.72-1
ii  libipc-run-perl                20180523.0-1
ii  liblist-moreutils-perl         0.416-1+b4
ii  libparse-debianchangelog-perl  1.2.0-13
ii  libpath-tiny-perl              0.108-1
ii  libtext-levenshtein-perl       0.13-1
ii  libtimedate-perl               2.3000-2
ii  libtry-tiny-perl               0.30-1
ii  liburi-perl                    1.76-1
ii  libxml-simple-perl             2.25-1
ii  libyaml-libyaml-perl           0.76+repack-1
ii  man-db                         2.8.5-2
ii  patchutils                     0.3.4-2
ii  perl [libdigest-sha-perl]      5.28.1-6
ii  t1utils                        1.41-3
ii  xz-utils                       5.2.4-1

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b5

Versions of packages lintian suggests:
ii  binutils-multiarch     2.31.1-16
ii  libhtml-parser-perl    3.72-3+b3
pn  libtext-template-perl  <none>

-- no debconf information

-- 
 \         “If history and science have taught us anything, it is that |
  `\     passion and desire are not the same as truth.” —E. O. Wilson, |
_o__)                                              _Consilience_, 1998 |
Ben Finney <bignose@debian.org>

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: lintian
Source-Version: 2.32.0

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 943684@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 31 Oct 2019 17:09:52 +0000
Source: lintian
Architecture: source
Version: 2.32.0
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 943684 943724
Changes:
 lintian (2.32.0) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * Skip entirely whitespace lines when checking the
     override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS tag.
     (Closes: #943684)
   * Don't build Git tags on salsa.
 .
   [ Felix Lechner ]
   * Clarify boolean return value in Collect::Binary->is_pkg_class.
     (Closes: #943724)
   * In Lintian::Collect::Binary, read from MLDBM in new facilites for
     details on scripts.
   * In Lintian::Collect::Package, read from BerkeleyDB in new facilites for
     details on binary package "control" scripts.
 .
   [ David Prévot ]
   * Update a file reference in the long description of the
     unnecessary-source-date-epoch-assignment tag.
 .
   [ Paul Wise ]
   * Add several spelling corrections.
Checksums-Sha1:
 69baba94b6186317bbc2c7739522dfd0fc8965cc 3999 lintian_2.32.0.dsc
 08ca8dff3eb308b8c13649f1d2993116f4057c92 1797148 lintian_2.32.0.tar.xz
 35a2129892a3e7ccaaec6c90ebe2b47ad314990c 16584 lintian_2.32.0_amd64.buildinfo
Checksums-Sha256:
 4706dd8b4a9dea1101f0859feedd1c4b1e147b63db418bffca0ba92f3fcf97c6 3999 lintian_2.32.0.dsc
 bcdbda51c3359fc6837825199cbc0fffaf56b5c855b7943c36dbc4ecf1b5211b 1797148 lintian_2.32.0.tar.xz
 cc82a39a2769f5dbb38fbc519eb6916982a9a9b96e5443a3a0036da59c49ec27 16584 lintian_2.32.0_amd64.buildinfo
Files:
 98fd7b4e7b9deeb9e035f33e1fe9d08f 3999 devel optional lintian_2.32.0.dsc
 be89af65e69fd73b7ba52eb5f51c88bc 1797148 devel optional lintian_2.32.0.tar.xz
 ac053b9e589d62dc139cad740883fab8 16584 devel optional lintian_2.32.0_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl27IygACgkQHpU+J9Qx
HlivUBAAw0VR09EIq2HbPmimBia0f6hCEPaNSTWt2iTr+9IRMAmaaQj8Q3zVtGFe
TCBLoT3fNEs0/GxKqJeoyELtBTZrFv2mp++gKbI4+4I9sf4K1IdrQct65voFV+om
TStUKo2li55NOW4+rsZwoXuIDx2fMGJ9a6OrCHRKfMpKuudBkT7l3SB4reKDo4bh
/5fwvXeYST4B6brmUQQa3ekMy6e8H3YwKl++PJeX4sDSzxljgDLsWH/oy5qAF5QX
sZztcBn/mEUv7DPS2Cwb4NPK5GbcRlUp/rtOSmWec9H2WTM98PGrdg9futmAh2Y0
Pf3+nt3464X+FXdfyA3e5vSps2GugJ7V1t3VNS1SOTLfe5YIxK3SbqcCXDKnVv3D
dkqDzQxP3LW+ON38RvE3zz1zJK0bjS4UL+rm+zhfgmFAceV8JyR7yxrK8JlU2pcq
1Rz01LTkqbf0KGcOI/ZjazfCVUFFGZ/k2jiTFqow9LMZuNdZGmfEU6Q4SAiabxB5
+Qtgk+CftAtzJMNSr2dnQl4aQtOuB8TfkmKPxHYw711wuX39yJvvvC+XYJR0WTRa
fxHlOtMZ0rUucQD+yjGCvLFgRHtnhbeG+YCxbnUOnfb4dh4yCv6lgmSbRZQsvSUt
cjb81sCS7T6BzZ2nLYRC28AnLVaCUNkFJs8c6HV4cHz7mpmbv3s=
=H/Bs
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: