[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#943684: lintian: Refine ‘override_dh_auto_test’ check to trigger only when different command



Package: lintian
Version: 2.15.0
Severity: normal

The check ‘override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS’
triggers incorrectly when the ‘override_dh_auto_test’ target merely
invokes ‘dh_auto_test’ with different options.

=====
$ grep '^override_dh_auto_test:' --after-context 3 debian/rules
override_dh_auto_test:
        dh_auto_test --buildsystem=makefile

$ lintian
[…]
I: python-daemon source: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS (line 25)
[…]
=====

The manual page ‘dh(1)’ explains of “override targets” that:

    The override target can then run the command with additional
    options, or run entirely different commands instead.

The above usage is a normal use of override target to change the
command-line option with which ‘dh_auto_test’ is invoked. This does
not need to be further wrapped with a ‘DEB_BUILD_OPTIONS’ test,
because that is done when ‘dh_auto_test’ runs.

Please change Lintian so that this check is done only when the
‘override_dh_auto_test’ target contains commands *other than* a
‘dh_auto_test’ command. The logic could be:

* If this is an ‘override_dh_auto_test’ target:
  * If there is exactly one command in the rule:
    * If the command name is ‘dh_auto_test’:
      * Do not inspect whether ‘DEB_BUILD_OPTIONS’ is tested.

  * Otherwise (different command; or multiple commands):
    * Inspect whether ‘DEB_BUILD_OPTIONS’ is tested. If not:
      * Emit ‘override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS’.


-- System Information:
Debian Release: 10.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-6-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_AU.UTF-8), LANGUAGE=en_AU.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_AU.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils                       2.31.1-16
ii  bzip2                          1.0.6-9.2~deb10u1
ii  diffstat                       1.62-1
ii  dpkg                           1.19.7
ii  dpkg-dev                       1.19.7
ii  file                           1:5.35-4+deb10u1
ii  gettext                        0.19.8.1-9
ii  gpg                            2.2.12-1+deb10u1
ii  intltool-debian                0.35.0+20060710.5
ii  libapt-pkg-perl                0.1.34+b1
ii  libarchive-zip-perl            1.64-1
ii  libcapture-tiny-perl           0.48-1
ii  libcgi-pm-perl                 4.40-1
ii  libclass-accessor-perl         0.51-1
ii  libclone-perl                  0.41-1+b1
ii  libdpkg-perl                   1.19.7
ii  libemail-valid-perl            1.202-1
ii  libfile-basedir-perl           0.08-1
ii  libio-async-perl               0.72-1
ii  libipc-run-perl                20180523.0-1
ii  liblist-moreutils-perl         0.416-1+b4
ii  libparse-debianchangelog-perl  1.2.0-13
ii  libpath-tiny-perl              0.108-1
ii  libtext-levenshtein-perl       0.13-1
ii  libtimedate-perl               2.3000-2
ii  libtry-tiny-perl               0.30-1
ii  liburi-perl                    1.76-1
ii  libxml-simple-perl             2.25-1
ii  libyaml-libyaml-perl           0.76+repack-1
ii  man-db                         2.8.5-2
ii  patchutils                     0.3.4-2
ii  perl [libdigest-sha-perl]      5.28.1-6
ii  t1utils                        1.41-3
ii  xz-utils                       5.2.4-1

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b5

Versions of packages lintian suggests:
ii  binutils-multiarch     2.31.1-16
ii  libhtml-parser-perl    3.72-3+b3
pn  libtext-template-perl  <none>

-- no debconf information

-- 
 \         “If history and science have taught us anything, it is that |
  `\     passion and desire are not the same as truth.” —E. O. Wilson, |
_o__)                                              _Consilience_, 1998 |
Ben Finney <bignose@debian.org>

Attachment: signature.asc
Description: PGP signature


Reply to: