Bug#907019: lintian: Please do not issue error init.d-script-should-always-start-service when reason is commented
Hi Chris,
On Fri, Aug 24, 2018 at 10:04:10AM +0100, Chris Lamb wrote:
> >
> > I admit I did not checked the lintian code but why do you expect so
> > many true-positives when ignoring those cases where some
> >
> > "# *"
>
> We are trying to warn about instances such as:
You are actually not warning but throwing an error about this
> # ENABLED="false"
> # ENABLED=false
> # DISABLED="true"
> # DISABLED=true
> # RUN="true"
> # RUN=true
> # PREFIXRUN="true"
> # PREFIXRUN=true
Finally I removed this now completely but I think what's the really
critical part here is reading the RUN variable inside the init file
which I removed in this commit as well:
https://salsa.debian.org/science-team/virtuoso-opensource/commit/d116f8b15d9a1d7d97f289dd71dacf60465f6fe1
So even if people might edit the default file according to the lintian
error its probably even more important to check whether the init file
might contain code to not start the service.
Do we want to turn this bug into something along this lines?
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: