[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#907019: lintian: Please do not issue error init.d-script-should-always-start-service when reason is commented



Hi Chris,

On Thu, Aug 23, 2018 at 12:10:45PM +0100, Chris Lamb wrote:
> 
> > Please check whether there is a comment sign before RUN (and others)
> > before issuing the error.
> 
> I understand the issue here but I fear this will result in many true-
> positives not being detected.

I admit I did not checked the lintian code but why do you expect so
many true-positives when ignoring those cases where some

   "# *"

prefixes the keyword lintian is seeking for?
 
> A proceeding comment does not universally signify that it is harmless

Can you give some example?  Do you think the harm is done inside the
package as is or rather that chances that some user of the installed
file simply removes the comment?  I would agree with the latter that
there is some good chance for the user to do something wrong but I see
no other issues here.

> therefore an override (or simply moving the comment) is likely more
> appropriate here.

I actually used an override and can perfectly cope with this but I'd
like to understand the idea behind this.

Kind regards

       Andreas.

-- 
http://fam-tille.de


Reply to: