Bug#916023: lintian: Please check if architecture could be "all" instead of "any"

[Dmitry Bogatov <KAction@debian.org>]

[2018-12-09 23:35] Chris Lamb <lamby@debian.org>
> > please add check, that binary package could have "Architecture: all"
> > instead of "any".
> 
> Hm, is this not the (experimental):
> 
>   https://lintian.debian.org/tags/package-contains-no-arch-dependent-files.html
> 
> … tag? :)

As of my version of lintian,

    lintian:
      Installed: 2.5.116
      Candidate: 2.5.116
      Version table:
     *** 2.5.116 500
            500 http://cdn-fastly.deb.debian.org/debian testing/main amd64 Packages
            500 http://cdn-fastly.deb.debian.org/debian sid/main amd64 Packages
            100 /var/lib/dpkg/status

it did not catch issue with src:simple-revision-control.

Let me try to understand why.

 * The tag 'package-contains-no-arch-dependent-files' is emitted
   in files.pm:2048

 * It is guarded by !$arch_dep_files. So for tag to be emitted,
   $arch_dep_files must be 0.

 * $arch_dep_files is 0 by default, and could be set to 1 at
   files.pm:424

	$arch_dep_files = 1 if $fname !~ m,^usr/share/,o && $fname ne 'usr/';

   This check is only about file names. According to this logic,
   anything outsite of /usr/share is arch-dependent.

To implement this tag properly, there is need to check for ELF magic in
files.