[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#890537: lintian: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS false positives



On Thu, 15 Feb 2018 19:40:53 +0000, Chris Lamb wrote:

> Fixed in Git, pending upload:
>   https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=4596dcddd6d26bc9e1e6492cf1055b67e1f06080

Wow, that was quick, thanks alot!
 
> Not sure how to deal with these, however:
> >      6	override_dh_auto_test:
> >      7		perl -MNet::Ping -e '(Net::Ping->new()->ping("127.0.0.1", 1)) ? \
> >      8			system("touch run_network_tests") : system("rm -rf run_network_tests");'
> >      9		dh_auto_test
> > 
> > libpoe-loop-tk-perl 1.305-1
> >      6	override_dh_auto_test:
> >      7		perl -MNet::Ping -e '(Net::Ping->new()->ping("127.0.0.1", 1)) ? \
> >      8			system("touch run_network_tests") : system("rm -rf run_network_tests");'
> >      9		xvfb-run -a dh_auto_test

Yeah, that's probably out of lintian's scope, unless it allows just
any commands.
 
> And this seems a little *too* esoteric for Lintian to realistically
> detect I'm afraid!
> > libwx-perl-datawalker-perl 0.02-1
> > 
> >      6	CMD=$(shell echo $@ | sed 's/override_//')
> >      7	
> >      8	override_dh_auto_test:
> >      9		xvfb-run -a $(CMD)

Sure; and it makes me chuckle each time I see it :)


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Eric Clapton: Swing Low Sweet Chariot

Attachment: signature.asc
Description: Digital Signature


Reply to: