Bug#890537: lintian: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS false positives
Package: lintian
Version: 2.5.75
Severity: minor
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
I went through some packages on
https://lintian.debian.org/tags/override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS.html
and noted the following false positives:
libcgi-application-plugin-config-simple-perl 1.01-2
6 override_dh_auto_test:
7 cp t/test.ini test.ini.bak
8 dh_auto_test
9 mv test.ini.bak t/test.ini
libconfig-identity-perl 0.0019-1
10 override_dh_auto_test:
11 [ ! -e $(CURDIR)/t/assets/gpg/random_seed ] || cp -v $(CURDIR)/t/assets/gpg/random_seed $(CURDIR)/t/assets/gpg/random_seed.save
12 CI_GPG=/usr/bin/gpg1 dh_auto_test
libdist-zilla-plugin-git-perl 2.043-1
13 override_dh_auto_test:
14 GIT_AUTHOR_EMAIL="pkg-perl-maintainers@lists.alioth.debian.org" \
15 GIT_AUTHOR_NAME="Debian Perl Group" \
16 dh_auto_test -- TEST_FILES="$(TEST_FILES)"
libfeed-find-perl 0.07-1
6 override_dh_auto_test:
7 [ ! -e inc/Spiffy.pm ] || mv inc/Spiffy.pm inc/Spiffy.pm-dontuse
8 [ ! -e inc/Test ] || mv inc/Test inc/Test-dontuse
9 NO_NETWORK=1 dh_auto_test
10 [ ! -e inc/Spiffy.pm-dontuse ] || mv inc/Spiffy.pm-dontuse inc/Spiffy.pm
11 [ ! -e inc/Test-dontuse ] || mv inc/Test-dontuse inc/Test
libgnupg-interface-perl 0.52-9
12 override_dh_auto_test:
13 mkdir -p $(BUILDHOME)
14 # this chmod can be dropped once CPAN #102651 is resolved upstream
15 chmod a+x test/fake-pinentry.pl
16 HOME=$(BUILDHOME) dh_auto_test
libgnupg-perl 0.19-3
6 override_dh_auto_test:
7 cp -r $(CURDIR)/test $(CURDIR)/test.ori
8 cp $(CURDIR)/debian/keyring/* $(CURDIR)/test/
9 dh_auto_test
10 rm -r $(CURDIR)/test && mv $(CURDIR)/test.ori $(CURDIR)/test
libhttp-daemon-ssl-perl 1.05-01-1
18 override_dh_auto_test:
19 test -e t/post.t && mv t/post.t t/testpost.t || :
20 dh_auto_test
21 mv t/testpost.t t/post.t
libmail-gnupg-perl 0.23-2
12 override_dh_auto_test:
13 chmod a+x t/fake-pinentry.pl
14 dh_auto_test -- --test_files="$(TEST_FILES)"
libmodule-info-perl 0.37-1
6 override_dh_auto_test:
7 mv t/lib/Test t/lib/Test.ori
8 dh_auto_test
9 mv t/lib/Test.ori t/lib/Test
libmojolicious-perl 7.61+dfsg-1
6 override_dh_auto_test:
7 mkdir blib/lib/Mojolicious/resources/public/mojo/jquery
8 ln -s /usr/share/javascript/jquery/jquery.js blib/lib/Mojolicious/resources/public/mojo/jquery
9 ln -s /usr/share/javascript/prettify/run_prettify.js blib/lib/Mojolicious/resources/public/mojo/prettify
10 dh_auto_test
11 rm blib/lib/Mojolicious/resources/public/mojo/prettify/run_prettify.js
12 rm blib/lib/Mojolicious/resources/public/mojo/jquery/jquery.js
13 rmdir blib/lib/Mojolicious/resources/public/mojo/jquery
libopenoffice-oodoc-perl 2.125-3
12 override_dh_auto_test:
13 rm -f blib/lib/OpenOffice/OODoc/config.xml
14 dh_auto_test
libpar-packer-perl 1.041-2
20 override_dh_auto_test:
21 ln -sf par.pl blib/script/par-archive
22 dh_auto_test
23 rm blib/script/par-archive
libpdl-graphics-gnuplot-perl 2.011-2
11 override_dh_auto_test:
12 true
libpoe-loop-event-perl 1.305-1
6 override_dh_auto_test:
7 perl -MNet::Ping -e '(Net::Ping->new()->ping("127.0.0.1", 1)) ? \
8 system("touch run_network_tests") : system("rm -rf run_network_tests");'
9 dh_auto_test
libpoe-loop-tk-perl 1.305-1
6 override_dh_auto_test:
7 perl -MNet::Ping -e '(Net::Ping->new()->ping("127.0.0.1", 1)) ? \
8 system("touch run_network_tests") : system("rm -rf run_network_tests");'
9 xvfb-run -a dh_auto_test
libwx-perl-datawalker-perl 0.02-1
6 CMD=$(shell echo $@ | sed 's/override_//')
7
8 override_dh_auto_test:
9 xvfb-run -a $(CMD)
While some of these constructs are not beautiful, and many do useless
things if dh_auto_test just exits, I think none of them runs the
test suite or leads to build failures or has any side effects.
On the plus side, I also found 5 real errors on the page and 2
ugly-enough-to-fix-as-well cases :)
Cheers,
gregor
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAlqF1yhfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgb67w//ayAsyLkeqiY6dHWipVmiys3xEaWEjNizoofFRsENlRuzf8Nhicyw6Sct
Fkqt1Ih7eGvPAvuYl8Nz/8emILEocydDql6j9P8b8ali/pEAV+ruia5TKiSwfG5C
AQH9wuf3fMSYYKFxbLotvORTdzOhF/QFRhagrrZPgxIBRiyKiBC9ASZIQyY1TU0p
dnwTZnf0ythRL3pEV1W38cCXyszY+cpPQR4+TJrVJQIvVJbr0AZoszC/pGiBNMqh
YCx1ovGtzneBwQYusnIl5d4h0cGwB+s/8mYMONlpClXSKJjHjsHqjgTKTRnjNP9x
xmWUay50pPy1ib/qVu9r4hJqoMR0spnHBo54kJf/3xl35WFjR+dsipD+Cn639R8b
9U+4EKmTsRkUICtCDk5IM/Yyokw2I5h4D3FXfnYhSfQuJ66sNnlYauf51F2jVKCU
y2ZHMJSvjjEYG/kZCTp1pdHDhCXIhAdjdVp3F+iHKEl22RZl8gTxdFynmgUx/oNL
I8AoSj/WB7ZAshnjLlhirtYLEI9gG/T5QQ8GGdhk5QS4+LhqkdK5lwmHlDSCRtJj
QmYUNLwSxdN4OiJNadPz6iNwyVW3EYpEevP7NgxzDSgFxaP1xqR/Ea1fEQJlXPq4
t/Kyl+aSgkRRuGtctOZfCLx7iE1zoV9YDMmwUAfHhHcXZp83h78=
=M1rc
-----END PGP SIGNATURE-----
Reply to: