Bug#888304: lintian: False-positive brace-expansion-in-debhelper-config-file

[Niels Thykier <niels@thykier.net>]

Chris Lamb:
> Hi Niels,
> 
>> a brace expansion requires a comma between the braces
> 
> So, the implementation actually matches a test case in the testsuite:
> 
>   https://anonscm.debian.org/git/lintian/lintian.git/tree/t/tests/debhelper-brace-expansion/debian/debian/debhelper-brace-problem-6.install#n1
> 
> Whilst the testsuite could be wrong (!) I just thought it requires
> double- checking. (Is this a dh_install vs. dh_link distinction…?)
> 
> 
> Best wishes,
> 

That particular test is wrong.  It would need a comma to be a true brace
expansion.

Also, note that dh_link do not do any glob expansion at all, so it
cannot have this problem in the first place.  If you use a {a,b} in
links, then you will always get a literal {a,b}.  That said, there is no
current need for literal {a,b}, so I would not bother coding support for
it right now.  It would just needlessly complicate the implementation.

Thanks,
~Niels