[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [lintian] 01/01: Update description of python-script-but-no-python-dep to refer to pybuild. (Closes: #660718)



On Mon, Dec 11, 2017 at 10:05:42PM +0000, Chris Lamb wrote:
[…]
>     Update description of python-script-but-no-python-dep to refer to pybuild. (Closes: #660718)
[…]
>   If you are using debhelper, adding <tt>${python:Depends}</tt> to the

I'd suggest to also mention ${python3:Depends} here if this tag also
applies to py3.

> - Depends field and ensuring dh_python2 or dh_python3 are run during
> - the build should take care of adding the correct dependency.
> + Depends field and ensuring dh-python, dh_python2 or dh_python3 are run
                               ^^^^^^^^^
dh-python (as in, the dh_python program) has been obsolated ages ago.
Whilst it's true that dh_python3 is in the dh-python binary package, I
wouldn't mention such technicality here, and instead only mention
dh_python

> + during the build should take care of adding the correct dependency.
>   .
>   In some cases a weaker relationship, such as Suggests or Recommends, will
>   be more appropriate.
> diff --git a/debian/changelog b/debian/changelog
> index 12b1d54..c672698 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -14,6 +14,9 @@ lintian (2.5.63) UNRELEASED; urgency=medium
>        report.  (Closes: #882684)
>      + [CL] Raise the certainty of multiarch-foreign-shared-library from
>        "wild guess" to "possible" on the suggestion of Helmut Grohne.
> +  * checks/scripts.desc:
> +    + [CL] Update description of python-script-but-no-python-dep to refer
> +      to pybuild.  (Closes: #660718)
            ^^^^^^^

And pybuild is a totally orthogonal tool that has nothing to do with
dependency generation.


Looking at the bug, the subject was about removing mentions of pycentral
and pysupport in favour of dh_python[23], which was apparently already
done at some point in the past.


I recommend to just revert this commit and manually close the bug as
"done at some point in the past already".

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: