[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 03/04: c/systemd: Don't emit systemd-service-file-missing-install-key if it contain an "Also=" section.



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch service-files-missing-install-key-false-positives
in repository lintian.

commit b4584f232df1f64dbabacbbac3b1496ccf2418f2
Author: Chris Lamb <lamby@debian.org>
Date:   Thu Sep 8 12:36:57 2016 +0100

    c/systemd: Don't emit systemd-service-file-missing-install-key if it contain an "Also=" section.
    
    Signed-off-by: Chris Lamb <lamby@debian.org>
---
 checks/systemd.pm                                                | 1 +
 t/tests/systemd-complex-service-file/debian/debian/install       | 1 +
 t/tests/systemd-complex-service-file/debian/debian/test4.service | 8 ++++++++
 3 files changed, 10 insertions(+)

diff --git a/checks/systemd.pm b/checks/systemd.pm
index aa0e1d0..b670c37 100644
--- a/checks/systemd.pm
+++ b/checks/systemd.pm
@@ -204,6 +204,7 @@ sub check_systemd_service_file {
         tag 'systemd-service-file-missing-install-key', $file,
           unless extract_service_file_values($file, 'Install', 'WantedBy',1)
           or extract_service_file_values($file, 'Install', 'RequiredBy',1)
+          or extract_service_file_values($file, 'Install', 'Also',1)
           or $file =~ m,@\.service$,;
     }
 
diff --git a/t/tests/systemd-complex-service-file/debian/debian/install b/t/tests/systemd-complex-service-file/debian/debian/install
index 10c1616..a4ea934 100644
--- a/t/tests/systemd-complex-service-file/debian/debian/install
+++ b/t/tests/systemd-complex-service-file/debian/debian/install
@@ -1,4 +1,5 @@
 debian/test.service lib/systemd/system/
 debian/test2.service lib/systemd/system/
 debian/test3.service lib/systemd/system/
+debian/test4.service lib/systemd/system/
 debian/test@.service lib/systemd/system/
diff --git a/t/tests/systemd-complex-service-file/debian/debian/test4.service b/t/tests/systemd-complex-service-file/debian/debian/test4.service
new file mode 100644
index 0000000..d63a719
--- /dev/null
+++ b/t/tests/systemd-complex-service-file/debian/debian/test4.service
@@ -0,0 +1,8 @@
+[Unit]
+Documentation=https://www.example.com/
+
+[Service]
+ExecStart=/usr/bin/test
+
+[Install]
+Also=test3

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: