[lintian] 02/04: c/systemd.pm: Don't emit systemd-service-file-missing-install-key for "template" .service files.
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch service-files-missing-install-key-false-positives
in repository lintian.
commit 7c6c8b12b962993fd3e06ee9453e25f3fef685fb
Author: Chris Lamb <lamby@debian.org>
Date: Thu Sep 8 12:33:36 2016 +0100
c/systemd.pm: Don't emit systemd-service-file-missing-install-key for "template" .service files.
Signed-off-by: Chris Lamb <lamby@debian.org>
---
checks/systemd.pm | 3 ++-
t/tests/systemd-complex-service-file/debian/debian/install | 3 ++-
t/tests/systemd-complex-service-file/debian/debian/test@.service | 5 +++++
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/checks/systemd.pm b/checks/systemd.pm
index b6a2153..aa0e1d0 100644
--- a/checks/systemd.pm
+++ b/checks/systemd.pm
@@ -203,7 +203,8 @@ sub check_systemd_service_file {
unless extract_service_file_values($file, 'Unit', 'Documentation',1);
tag 'systemd-service-file-missing-install-key', $file,
unless extract_service_file_values($file, 'Install', 'WantedBy',1)
- or extract_service_file_values($file, 'Install', 'RequiredBy',1);
+ or extract_service_file_values($file, 'Install', 'RequiredBy',1)
+ or $file =~ m,@\.service$,;
}
return 1;
diff --git a/t/tests/systemd-complex-service-file/debian/debian/install b/t/tests/systemd-complex-service-file/debian/debian/install
index f4ca3c8..10c1616 100644
--- a/t/tests/systemd-complex-service-file/debian/debian/install
+++ b/t/tests/systemd-complex-service-file/debian/debian/install
@@ -1,3 +1,4 @@
debian/test.service lib/systemd/system/
debian/test2.service lib/systemd/system/
-debian/test3.service lib/systemd/system/
\ No newline at end of file
+debian/test3.service lib/systemd/system/
+debian/test@.service lib/systemd/system/
diff --git a/t/tests/systemd-complex-service-file/debian/debian/test@.service b/t/tests/systemd-complex-service-file/debian/debian/test@.service
new file mode 100644
index 0000000..d54ea5d
--- /dev/null
+++ b/t/tests/systemd-complex-service-file/debian/debian/test@.service
@@ -0,0 +1,5 @@
+[Unit]
+Documentation=https://www.example.com/
+
+[Service]
+ExecStart=/usr/bin/test
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: