Bug#871956: lintian: false positive: binary-file-built-without-LFS-support on x32
hi Guillem, all,
On Sun, 3 Sep 2017, Guillem Jover wrote:
When you define _FILE_OFFSET_BITS=64 the interfaces are transparently
mapped to the 64-bit variants and no other code change is required. So
you *must* not be switching from foo to foo64 in the call sites. This
is IMO the preferred way to enable LFS.
Do you mean that the preferred way is to always hardwire _FILE_OFFSET_BITS to
64? Or is using AC_SYS_LARGEFILE, which seems to me to *not* set this on amd64,
also a long-term sustainable solution? (To me it seems that if some systems
do not need to define it to 64, and if AC_SYS_LARGEFILE handles this correctly,
then it's best to allow AC_SYS_LARGEFILE to do this.)
Nope, that looks wrong. The __USE_* macros are internal implementation
details, and applications should not be using those. In addition you
should just be using pread() and pwrite(), which will call the correct
interfaces.
OK, thanks for the correction.
[So presumably this means that the only bug in mpgrafic-0.3.15-1 in terms of LFS
is the failure to #include config.h.]
That patch needs to be reverted. I can provide a new patch explaining
in more detail this though and giving more pointers perhaps.
Please go ahead - the documentation bug is here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874078
Cheers
Boud
Reply to: