[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#818962: fix the php-script-but-no-phpX-cli-dep error



lgtm

thank you very much for fixing this

-- 
Ondřej Surý <ondrej@sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
Knot Resolver (https://www.knot-resolver.cz/) – secure, privacy-aware,
fast DNS(SEC) resolver

On Thu, Nov 3, 2016, at 22:56, Antonio Ospite wrote:
> On Tue, 1 Nov 2016 10:51:41 +0100
> Antonio Ospite <ao2@ao2.it> wrote:
> 
> > On Tue, 1 Nov 2016 00:10:15 +0100
> > Antonio Ospite <ao2@ao2.it> wrote:
> [...]
> > [...]
> > >
> > > This also demote the case of when the interpreter uses a version number
> > > in the interpreter to a "unusual-interpreter" warning.
> > > 
> > 
> > After thinking a little more about it, this still isn't right, we
> > should get the php-script-but-no-php-cli-dep error also when the
> > shebang line has an "unusual" interpreter, like /usr/bin/php7.0.
> > 
> 
> OK, the updated patches are attached.
> 
> The changes since v1 are:
>  - the dependency checks are now triggered also when an unusual
>    interpreter is found
> 
> Ondřej do you have any comment?
> 
> Thanks,
>    Antonio
> 
> -- 
> Antonio Ospite
> https://ao2.it
> https://twitter.com/ao2it
> 
> A: Because it messes up the order in which people normally read text.
>    See http://en.wikipedia.org/wiki/Posting_style
> Q: Why is top-posting such a bad thing?
> Email had 2 attachments:
> + 0001-Give-error-for-packages-shipping-php-scripts-but-not.patch
>   11k (text/x-diff)
> + 0002-Add-a-new-php-script-with-unusual-interpreter-check.patch
>   6k (text/x-diff)


Reply to: