[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#818962: fix the php-script-but-no-phpX-cli-dep error



On Tue, 1 Nov 2016 00:10:15 +0100
Antonio Ospite <ao2@ao2.it> wrote:

> Hi,
> 
> I am attaching a revised patchset to address this bug.
> 
> Patch 0001 is based on Mathieu's work, but I think it follows more
> strictly what Ondřej had in mind: the error tells the user to depend on
> php-cli when a package contains a php script. The error triggers also
> when a phpX-cli dep is used.
> 
[...]
> From 97e3a3a3eea534c25842ed61e8ab3950028b9138 Mon Sep 17 00:00:00 2001
> From: Antonio Ospite <ao2@ao2.it>
> Date: Thu, 3 Mar 2016 10:50:36 +0100
> Subject: [PATCHv2 1/2] Give error for packages shipping php scripts but not
>  depending on php-cli
[...]
>
> This also demote the case of when the interpreter uses a version number
> in the interpreter to a "unusual-interpreter" warning.
> 

After thinking a little more about it, this still isn't right, we
should get the php-script-but-no-php-cli-dep error also when the
shebang line has an "unusual" interpreter, like /usr/bin/php7.0.

What do you think?

If so I will send an updated patchset, but I'm waiting a couple of
days, in case there are some other comments.

Please review :)

Thanks,
   Antonio

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?


Reply to: