[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 02/04: r/html_reports: short circuit a loop if possible



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 2a1500e9c661258bf1bf03a3c643e1b8b7a1ee84
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Apr 24 16:52:10 2016 +0000

    r/html_reports: short circuit a loop if possible
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 reporting/html_reports | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/reporting/html_reports b/reporting/html_reports
index 6bf0799..efcf85a 100755
--- a/reporting/html_reports
+++ b/reporting/html_reports
@@ -245,10 +245,13 @@ for my $maintainer (@maintainers) {
           || $by_uploader{$maintainer}{$source};
         for my $version (keys %$versions) {
             $versions->{$version} = [sort by_tag @{ $versions->{$version} }];
+            next if not $error_clean;
             my $tags = $versions->{$version};
             for my $tag (@$tags) {
-                $error_clean = 0 if ($tag->{code} eq 'E');
-                $error_clean = 0 if ($tag->{code} eq 'W');
+                if ($tag->{code} eq 'E' or $tag->{code} eq 'W') {
+                    $error_clean = 0;
+                    last;
+                }
             }
         }
     }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: