[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 03/04: c/shared-libs: Prefer uniq to makeshift implementation



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit bb4dea432b14ca2e337acfc69e14f0fe80276901
Author: Niels Thykier <niels@thykier.net>
Date:   Sun Apr 24 17:35:31 2016 +0000

    c/shared-libs: Prefer uniq to makeshift implementation
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 checks/shared-libs.pm | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/checks/shared-libs.pm b/checks/shared-libs.pm
index 58e39d2..9a7eeb0 100644
--- a/checks/shared-libs.pm
+++ b/checks/shared-libs.pm
@@ -24,7 +24,7 @@ use warnings;
 use autodie;
 
 use File::Basename;
-use List::MoreUtils qw(any none);
+use List::MoreUtils qw(any none uniq);
 
 use Lintian::Data;
 use Lintian::Relation;
@@ -414,8 +414,7 @@ sub run {
             #
             # Deduplicate the list of dependencies before warning so
             # that we don't duplicate warnings.
-            my %seen;
-            @shlibs_depends = grep { !$seen{$_}++ } @shlibs_depends;
+            @shlibs_depends = uniq(@shlibs_depends);
             for my $depend (@shlibs_depends) {
                 unless ($provides->implies($depend)) {
                     tag 'shlibs-declares-dependency-on-other-package', $depend;
@@ -604,8 +603,7 @@ sub run {
         #
         # Deduplicate the list of dependencies before warning so that we don't
         # duplicate warnings.
-        my %seen;
-        @symbols_depends = grep { !$seen{$_}++ } @symbols_depends;
+        @symbols_depends = uniq(@symbols_depends);
         for my $depend (@symbols_depends) {
             my $d = $depend;
             $d =~ s/ \#MINVER\#$//;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: