[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/02: Use data file for pedantic warning on debhelper depends version.



This is an automated email from the git hooks/post-receive script.

broucaries-guest pushed a commit to branch master
in repository lintian.

commit 8141e4a1dc5a50a774085eb53efda822cc22e9ee
Author: Bastien ROUCARIÈS <roucaries.bastien+debian@gmail.com>
Date:   Mon Aug 3 18:03:48 2015 +0200

    Use data file for pedantic warning on debhelper depends version.
---
 checks/debhelper.pm         | 8 +++-----
 data/debhelper/compat-level | 5 +++++
 debian/changelog            | 2 ++
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/checks/debhelper.pm b/checks/debhelper.pm
index 53a2f2e..8dc985f 100644
--- a/checks/debhelper.pm
+++ b/checks/debhelper.pm
@@ -28,10 +28,6 @@ use Lintian::Relation;
 use Lintian::Tags qw(tag);
 use Lintian::Util qw(strip);
 
-# If compat is less than or equal to this, then a missing version
-# for this level is only a pedantic issue.
-use constant PEDANTIC_COMPAT => 8;
-
 # If there is no debian/compat file present but cdbs is being used, cdbs will
 # create one automatically.  Currently it always uses compatibility level 5.
 # It may be better to look at what version of cdbs the package depends on and
@@ -45,6 +41,8 @@ my $dh_ver_deps= Lintian::Data->new('debhelper/dh_commands-manual', qr/\|\|/o);
 my $dh_addons = Lintian::Data->new('debhelper/dh_addons', '=');
 my $dh_addons_manual
   = Lintian::Data->new('debhelper/dh_addons-manual', qr/\|\|/o);
+my $compat_level = Lintian::Data->new('debhelper/compat-level',qr/=/);
+
 
 my $MISC_DEPENDS = Lintian::Relation->new('${misc:Depends}');
 
@@ -404,7 +402,7 @@ sub run {
     unless ($bdepends->implies("debhelper (>= $level~)")){
         my $tagname = 'package-needs-versioned-debhelper-build-depends';
         $tagname = 'package-lacks-versioned-build-depends-on-debhelper'
-          if ($level <= PEDANTIC_COMPAT);
+          if ($level <= $compat_level->value('pedantic'));
 
         tag $tagname, $level;
     }
diff --git a/data/debhelper/compat-level b/data/debhelper/compat-level
new file mode 100644
index 0000000..e67691f
--- /dev/null
+++ b/data/debhelper/compat-level
@@ -0,0 +1,5 @@
+# warn if no versionned depend below this level
+pedantic=8
+# warn if does not depend on this debhelper level
+recommended=9
+
diff --git a/debian/changelog b/debian/changelog
index e3f2329..fd373f7 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -16,6 +16,8 @@ lintian (2.5.35) UNRELEASED; urgency=medium
       Thanks to Helmut Grohne remainder.
     + [BR] pre-depends-directly-on-multiarch-support does not need debhelper
       for being raised. Suggest to depends to debhelper >= 9.
+  * checks/debhelper.{desc,pm}:
+    + [BR] Use data file for pedantic warning on debhelper depends version.
   * checks/fields.desc:
     + [JW] Fix spelling of the word "indicate".
   * checks/scripts.desc:

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: