[lintian] 02/02: Detect not recommanded and experimental debhelper version
This is an automated email from the git hooks/post-receive script.
broucaries-guest pushed a commit to branch master
in repository lintian.
commit 5b87f7c2ae9dd34a983b435b21bdf4ab2f201d81
Author: Bastien ROUCARIÈS <roucaries.bastien+debian@gmail.com>
Date: Mon Aug 3 18:33:04 2015 +0200
Detect not recommanded and experimental debhelper version
Will help statistic making
---
checks/debhelper.desc | 26 ++++++++++++++++++++++
checks/debhelper.pm | 6 ++++-
data/debhelper/compat-level | 6 ++++-
debian/changelog | 1 +
.../debian/debian/compat | 1 +
t/tests/debhelper-compat-experimental/desc | 9 ++++++++
t/tests/debhelper-compat-experimental/tags | 2 ++
t/tests/debhelper-compat-old/debian/debian/compat | 1 +
t/tests/debhelper-compat-old/desc | 9 ++++++++
t/tests/debhelper-compat-old/tags | 1 +
10 files changed, 60 insertions(+), 2 deletions(-)
diff --git a/checks/debhelper.desc b/checks/debhelper.desc
index 3c76579..a08e3a9 100644
--- a/checks/debhelper.desc
+++ b/checks/debhelper.desc
@@ -152,6 +152,32 @@ Info: The debhelper compatibility version used by this package is marked
<tt>debian/rules</tt>. If it is not set in either place, debhelper
defaults to the deprecated compatibility version 1.
+Tag: package-uses-old-debhelper-compat-version
+Severity: pedantic
+Certainty: certain
+Ref: debhelper(7)
+Info: The debhelper compatibility version used by this package is marked
+ as not recommended by the debhelper developer. You may consider
+ using a recommanded compatibility version.
+ .
+ The compatibility version can be set in (preferred)
+ <tt>debian/compat</tt> or by setting and exporting DH_COMPAT in
+ <tt>debian/rules</tt>. If it is not set in either place, debhelper
+ defaults to the deprecated compatibility version 1.
+
+Tag: package-uses-experimental-debhelper-compat-version
+Severity: pedantic
+Certainty: certain
+Ref: debhelper(7)
+Info: The debhelper compatibility version used by this package is marked
+ as experimental by the debhelper developer. You may consider
+ using a stable compatibility version.
+ .
+ The compatibility version can be set in (preferred)
+ <tt>debian/compat</tt> or by setting and exporting DH_COMPAT in
+ <tt>debian/rules</tt>. If it is not set in either place, debhelper
+ defaults to the deprecated compatibility version 1.
+
Tag: debhelper-but-no-misc-depends
Severity: normal
Certainty: possible
diff --git a/checks/debhelper.pm b/checks/debhelper.pm
index 8dc985f..c23c340 100644
--- a/checks/debhelper.pm
+++ b/checks/debhelper.pm
@@ -271,8 +271,12 @@ sub run {
$level = $cdbscompat;
}
$level ||= 1;
- if ($level < 5) {
+ if ($level < $compat_level->value('deprecated')) {
tag 'package-uses-deprecated-debhelper-compat-version', $level;
+ } elsif ($level < $compat_level->value('recommended')) {
+ tag 'package-uses-old-debhelper-compat-version', $level;
+ } elsif ($level >= $compat_level->value('experimental')) {
+ tag 'package-uses-experimental-debhelper-compat-version', $level;
}
if ($seendhcleank and $level >= 7) {
diff --git a/data/debhelper/compat-level b/data/debhelper/compat-level
index e67691f..315607e 100644
--- a/data/debhelper/compat-level
+++ b/data/debhelper/compat-level
@@ -1,5 +1,9 @@
# warn if no versionned depend below this level
pedantic=8
-# warn if does not depend on this debhelper level
+# warn (pedantic) if does not depend on this debhelper level
recommended=9
+# warn if below this level
+deprecated=5
+# warn if equal or above
+experimental=10
diff --git a/debian/changelog b/debian/changelog
index fd373f7..e5c6941 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -18,6 +18,7 @@ lintian (2.5.35) UNRELEASED; urgency=medium
for being raised. Suggest to depends to debhelper >= 9.
* checks/debhelper.{desc,pm}:
+ [BR] Use data file for pedantic warning on debhelper depends version.
+ + [BR] Detect not recommended and experimental debhelper version.
* checks/fields.desc:
+ [JW] Fix spelling of the word "indicate".
* checks/scripts.desc:
diff --git a/t/tests/debhelper-compat-experimental/debian/debian/compat b/t/tests/debhelper-compat-experimental/debian/debian/compat
new file mode 100644
index 0000000..f599e28
--- /dev/null
+++ b/t/tests/debhelper-compat-experimental/debian/debian/compat
@@ -0,0 +1 @@
+10
diff --git a/t/tests/debhelper-compat-experimental/desc b/t/tests/debhelper-compat-experimental/desc
new file mode 100644
index 0000000..8687e9e
--- /dev/null
+++ b/t/tests/debhelper-compat-experimental/desc
@@ -0,0 +1,9 @@
+Testname: debhelper-compat-experimental
+Sequence: 6000
+Version: 1.0
+Description: Test for old debian/compat file
+Skeleton: pedantic
+Options: --pedantic -I -E
+Test-Depends: debhelper (>= 9.20141221),
+Test-For:
+ package-uses-experimental-debhelper-compat-version
diff --git a/t/tests/debhelper-compat-experimental/tags b/t/tests/debhelper-compat-experimental/tags
new file mode 100644
index 0000000..6cd674d
--- /dev/null
+++ b/t/tests/debhelper-compat-experimental/tags
@@ -0,0 +1,2 @@
+P: debhelper-compat-experimental source: package-uses-experimental-debhelper-compat-version 10
+W: debhelper-compat-experimental source: package-needs-versioned-debhelper-build-depends 10
diff --git a/t/tests/debhelper-compat-old/debian/debian/compat b/t/tests/debhelper-compat-old/debian/debian/compat
new file mode 100644
index 0000000..45a4fb7
--- /dev/null
+++ b/t/tests/debhelper-compat-old/debian/debian/compat
@@ -0,0 +1 @@
+8
diff --git a/t/tests/debhelper-compat-old/desc b/t/tests/debhelper-compat-old/desc
new file mode 100644
index 0000000..562d890
--- /dev/null
+++ b/t/tests/debhelper-compat-old/desc
@@ -0,0 +1,9 @@
+Testname: debhelper-compat-old
+Sequence: 6000
+Version: 1.0
+Description: Test for old debian/compat file
+Skeleton: pedantic
+Options: --pedantic -I -E
+Test-Depends: debhelper (>= 9),
+Test-For:
+ package-uses-old-debhelper-compat-version
diff --git a/t/tests/debhelper-compat-old/tags b/t/tests/debhelper-compat-old/tags
new file mode 100644
index 0000000..a1195ab
--- /dev/null
+++ b/t/tests/debhelper-compat-old/tags
@@ -0,0 +1 @@
+P: debhelper-compat-old source: package-uses-old-debhelper-compat-version 8
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: