[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: html_reports: Move tag quoting to template



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 5e46e6543ac0962eb689f31cf10fb5d78718ae28
Author: Niels Thykier <niels@thykier.net>
Date:   Sat Mar 28 23:08:37 2015 +0100

    html_reports: Move tag quoting to template
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 reporting/html_reports       | 4 ++--
 reporting/templates/tag.tmpl | 9 +++++----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/reporting/html_reports b/reporting/html_reports
index 2683fc7..c67ad91 100755
--- a/reporting/html_reports
+++ b/reporting/html_reports
@@ -193,7 +193,7 @@ my (%statistics, %tag_statistics);
 #
 # { 'gnubg' => {
 #       '0.15~20061120-1' => [
-#           { code      => 'W', # Either 'O' or same as $tag_info->code)
+#           { code      => 'W', # Either 'O' or same as $tag_info->code
 #             package   => 'gnubg',
 #             version   => '0.15~20061120-1',
 #             area      => 'main',
@@ -354,7 +354,7 @@ for my $tag (sort $profile->tags(1)) {
 
     my %maint_data = (
         description => $description,
-        tag         => html_quote($tag),
+        tag         => $tag,
         code        => $info->code,
         tags        => $by_tag{$tag},
         graphs      => $GRAPHS,
diff --git a/reporting/templates/tag.tmpl b/reporting/templates/tag.tmpl
index ae5e2e1..7880940 100644
--- a/reporting/templates/tag.tmpl
+++ b/reporting/templates/tag.tmpl
@@ -1,5 +1,6 @@
-{ head("Lintian Tag: $tag") }
-  <h1><span class="type-{$code}">{$code}</span> {$tag}</h1>
+{ my $q_tag = html_quote($tag);
+  head("Lintian Tag: ${q_tag}") }
+  <h1><span class="type-{$code}">{$code}</span> {${q_tag}}</h1>
 
   <p>
     All reports of {$tag} for the archive. The extended description of this
@@ -14,10 +15,10 @@
     if ($graphs) {
         my $graph_link = resource_path("${tag}.svg");
         $OUT .= qq(  <p>\n);
-        $OUT .= qq(    Evolution of the $tag Lintian tag over the past\n);
+        $OUT .= qq(    Evolution of the ${q_tag} Lintian tag over the past\n);
         $OUT .= qq(    $graphs_days days:</p>\n);
         $OUT .= qq(  <div class="graph"><a href="${graph_link}"><img class="graph"\n);
-        $OUT .= qq(    src="${graph_link}" alt="History of $tag"\n);
+        $OUT .= qq(    src="${graph_link}" alt="History of ${q_tag}"\n);
         $OUT .= qq(    /></a></div>\n);
     }
     $OUT .= qq(<p>Emitted (non-overridden): $statistics{count}, );

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: