[lintian] 02/02: r/templates: Consistently quote tag names
This is an automated email from the git hooks/post-receive script.
nthykier pushed a commit to branch master
in repository lintian.
commit 8ff1b1c7e989d7f307692f4fb6a9887b021c94ef
Author: Niels Thykier <niels@thykier.net>
Date: Sat Mar 28 22:55:04 2015 +0100
r/templates: Consistently quote tag names
Previously, the tag names were not quoted on the tags indices.
However, given we are quoting them on the maintainer pages, we
should just be consistent and do it every where.
Signed-off-by: Niels Thykier <niels@thykier.net>
---
reporting/templates/tags-all.tmpl | 3 ++-
reporting/templates/tags-severity.tmpl | 3 ++-
reporting/templates/tags.tmpl | 3 ++-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/reporting/templates/tags-all.tmpl b/reporting/templates/tags-all.tmpl
index ad94cd7..884c907 100644
--- a/reporting/templates/tags-all.tmpl
+++ b/reporting/templates/tags-all.tmpl
@@ -10,6 +10,7 @@
{
for my $tag (sort $profile->tags (1)) {
my $text;
+ my $q_tag = html_quote($tag);
if ($stats{$tag}) {
my $packages = $stats{$tag}{'packages'};
my $count = $stats{$tag}{'count'};
@@ -19,7 +20,7 @@
} else {
$text = 'Not emitted';
}
- $OUT .= qq( <li><a href="${path_prefix}tags/$tag.html">$tag</a>)
+ $OUT .= qq( <li><a href="${path_prefix}tags/${q_tag}.html">${q_tag}</a>)
. " ($text)"
. "</li>\n";
}
diff --git a/reporting/templates/tags-severity.tmpl b/reporting/templates/tags-severity.tmpl
index 11f2fea..758c310 100644
--- a/reporting/templates/tags-severity.tmpl
+++ b/reporting/templates/tags-severity.tmpl
@@ -26,7 +26,8 @@
my $packages = $stats{$tag}{'packages'};
my $count = $stats{$tag}{'count'};
my $overrides = $stats{$tag}{'overrides'};
- $OUT .= qq( <li><a href="${path_prefix}tags/$tag.html">$tag</a>)
+ my $q_tag = html_quote($tag);
+ $OUT .= qq( <li><a href="${path_prefix}tags/${q_tag}.html">${q_tag}</a>)
. " ($packages packages, $count tags"
. ($overrides > 0 ? ", plus $overrides overrides" : "")
. ")</li>\n";
diff --git a/reporting/templates/tags.tmpl b/reporting/templates/tags.tmpl
index 255e63b..3654af7 100644
--- a/reporting/templates/tags.tmpl
+++ b/reporting/templates/tags.tmpl
@@ -10,6 +10,7 @@
<ul>
{
for my $tag (sort keys %stats) {
+ my $q_tag = html_quote($tag);
my $packages = $stats{$tag}{'packages'};
my $count = $stats{$tag}{'count'};
my $packages_str = $packages != 1 ?
@@ -25,7 +26,7 @@
$overrides_str = ", plus $overrides overrides";
}
}
- $OUT .= qq( <li><a href="${path_prefix}tags/$tag.html">$tag</a>)
+ $OUT .= qq( <li><a href="${path_prefix}tags/${q_tag}.html">${q_tag}</a>)
. " ($packages_str, ${count_str}${overrides_str}"
. ")</li>\n";
}
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: