[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#779866: marked as done (lintian: debian/copyright parser emits non-understandable warnings)

Your message dated Sun, 15 Mar 2015 21:58:19 +0100
with message-id <5505F26B.2090509@thykier.net>
and subject line Re: Bug#779866: lintian: debian/copyright parser emits non-understandable warnings
has caused the Debian Bug report #779866,
regarding lintian: debian/copyright parser emits non-understandable warnings
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
779866: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779866
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.5.30-150-g79ba4df
Severity: normal

The parser for debian/copyright seems to be under heavy development.
Unfortunately I only learn about the (possible) problems after upload,
i.e. it is not possible to work on them in unstable and fix the issues
before upload.

Furthermore (and the core of this bug) is the problem that the emitted
errors are hard to understand, so uploads become something like trial
and error.

The two most recent occasions for me are
a) dep5-copyright-license-name-not-unique
   cf. to
   https://lists.debian.org/debian-mentors/2015/03/msg00029.html for a
   discussion and subsequent bug from Charles Plessy (#779676)

b) dep5-file-paragraph-reference-header
   which I now receive after "fixing" the previous error.

I tried to understand the first sentence of the long description, but
failed:

One of the file paragraph reference in the license field a standalone
license defined in the header paragraph.

Also the second sentence is very long and quite difficult to
understand (at least for non native speakers).

In my opinion two actions should resolve this issue:

a) Provide lintian to unstable *before* using it to check uploaded
   packages. This enables maintainers to upload lintian clean
   packages.

b) Spend a little more time for the description of the tag.

c) Reword dep5-file-paragraph-reference-header, possibly using simpler
   english and several sentences.

-- 
      Dr. Helge Kreutzmann                     debian@helgefjell.de
           Dipl.-Phys.                   http://www.helgefjell.de/debian.php
        64bit GNU powered                     gpg signed mail preferred
           Help keep free software "libre": http://www.ffii.de/

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
On 2015-03-15 16:34, Helge Kreutzmann wrote:
> Hello Niels,
> [...]
>>
>> If my assertion is correct, the attached patch should solve your issue.
>>
>> Alternatively, insert the first "files" paragraph between the header and
>> the first "license" paragraph should also work around the issue.
> 
> Ok, then I "ignore" this lintian tag for the moment.
> 

Hi Helge,

I extended the patch with a test case and have now pushed it to master.
 Thanks for helping us catch this before it was released. :)

I also updated lintian.d.o, so the false-positives should slowly
disappear now.


As we are dealing with a bug in an unreleased version, I will close this
bug now.  This is our usual custom for this kind of bugs.


>>>>   Though as explained above, in this particular case, the tags are live
>>>> on the website prior to a release (and therefore, also a review).
>>>>
>>>> If you are unhappy with the tag descriptions, I am happy to revised
>>>> descriptions.
>>>
>>> Well, as I don't really understand the text I'm unable to provide an
>>> updated version, hopefully debian-l10n-english will do (they usually).
>>>
>>
>> Are you willing to take a stab at it, if the above patch works? :)
>>
>> We should probably also rename the tag to say "header-paragraph" for
>> clarity.
> 
> I'm usually not involved on debian-l10n english, and I believe Justin
> is much more capable of proof reading text (I'm not a native speaker)
> I don't think I'm of much help here. 
> 

Ok, in the interim, I rewrote the description to something that I hope
is easier to read.  It could probably still use a review though.  If you
spot anything obvious, feel free to follow up with improvements to it.

>>> Btw. I saw that you use po4a. Are you really intending for localizations
>>> to lintian tags? 
>>
>> Yes.  I thought it would be beneficial as it would provide people with
>> the description in their native language /and/ provide us with (more)
>> reviewers of the tag descriptions.
>>
>> Sadly, so far we got 0 translations. I believe we got one, who wanted to
>> start out on the German translations recently though.  I should probably
>> ping him for an update.
> 
> As I'm involved in debian-l10n-german if you like you can send me the
> name of the prospective translator and I can check on that.
> 
> Thanks again and sorry for the long response time.
> 
> Greetings
> 
>         Helge
> 

It is Stephan Beck.  The last I heard from him on the translations was
in [1].

Thanks,
~Niels

[1] https://lists.debian.org/debian-lint-maint/2015/01/msg00032.html

--- End Message ---
Reply to: