[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#779866: lintian: debian/copyright parser emits non-understandable warnings



Hello Niels,
On Fri, Mar 06, 2015 at 11:50:06PM +0100, Niels Thykier wrote:
> On 2015-03-05 19:40, Helge Kreutzmann wrote:
> > Package: lintian
> > Version: 2.5.30-150-g79ba4df
> > Severity: normal
> > 
> > The parser for debian/copyright seems to be under heavy development.
> 
> Hi,
> 
> The DEP-5 copyright check "only" got two new tag (the ones you list
> below) since the last release to unstable and the actual changes to the
> check are rather modest.

Ok, sorry for the wrong assumption. (It just seems that my
debian/copyright is lintian unclean on every second upload).

> > Unfortunately I only learn about the (possible) problems after upload,
> > i.e. it is not possible to work on them in unstable and fix the issues
> > before upload.
> > 
> > Furthermore (and the core of this bug) is the problem that the emitted
> > errors are hard to understand, so uploads become something like trial
> > and error.
> > 
> 
> 
> Indeed, you would be unable to test these with the packaged version of
> lintian.  However, it is fairly uncomplicated to run lintian from a git
> checkout.
> 
>   $ git clone https://anonscm.debian.org/git/lintian/lintian.git
>   $ lintian/frontend/lintian [options] path/to/your/package.changes
> 
> I fully understand if you do not want to do that.  I am just mentioning
> the option, in case you might find it useful.

I pulled it. It's just awkward, as my primary build machine has no
direct internet access. So hopefully the unstable version becomes the
primary soon.

> > The two most recent occasions for me are
> > a) dep5-copyright-license-name-not-unique
> >    cf. to
> >    https://lists.debian.org/debian-mentors/2015/03/msg00029.html for a
> >    discussion and subsequent bug from Charles Plessy (#779676)
> > 
> 
> Indeed, there is a separate bug for that tag, so lets keep the
> discussion about that there.

Fully agreed.

> > b) dep5-file-paragraph-reference-header
> >    which I now receive after "fixing" the previous error.
> > 
> 
> Do your "Header-paragraph" contain a license field and does a
> "Files"-paragraph reference the license of that field?  That seems to be
> what this is checking for.

My debian/copyright now starts as follows (shortend):
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: goobox
Upstream-Contact: Paolo Bacchilega <paobac@src.gnome.org>
                  Paolo Bacchilega  <paobac@svn.gnome.org>
                  Paolo Bacchilega  <paobac@cvs.gnome.org>
Source: http://ftp.gnome.org/pub/GNOME/sources/goobox/

License: GPL-2+
 Some text

License: GPL-2
 Same text

License: RESTRICTED
 Some other text

...

Files: *
Copyright: 2004-2015 Paolo Bacchilega <paobac@src.gnome.org>
License: GPL-2+

Files: configure.ac
Copyright: 2009-2015 Paolo Bacchilega <paobac@src.gnome.org>
           2012 György Balló <ballogy@freestart.hu>
License: GPL-2+

The error is on line 625 which (and the few following lines) read:
Files: debian/*
Copyright: 2004,2005 Dan Korostelev <nadako@gmail.com>
           2006 Steve Langasek <vorlon@debian.org>
           2006 Matej Vela <vela@debian.org>
           2006,2007 Daniel Baumann <daniel@debian.org>
           2006-2015 Helge Kreutzmann <debian@helgefjell.de>
License: GPL-2+

> Generally, we do that.  Though in some cases, we do rapid deploys to
> lintian.d.o for updating the reporting framework.  This time, we had a
> nasty issue where the reporting framework suffered from "out of memory"
> issues causing parts of it to fail.  This is the reason why these checks
> are now live without being released.

Ok, I perfectly understand.

> > b) Spend a little more time for the description of the tag.
> > 
> > c) Reword dep5-file-paragraph-reference-header, possibly using simpler
> >    english and several sentences.
> > 
> 
> The tag descriptions were drafted by a person with dyslexia.  Under
> normal circumstances, the new tag descriptions are sent to review on
> debian-l18n(-english?) prior to a release and they would assist with
> maturing the tag description.

Ok, then this is a combination of unfortunate circumstances, which is
normally not allowed to happen. Thanks for the good process!

>   Though as explained above, in this particular case, the tags are live
> on the website prior to a release (and therefore, also a review).
> 
> If you are unhappy with the tag descriptions, I am happy to revised
> descriptions.

Well, as I don't really understand the text I'm unable to provide an
updated version, hopefully debian-l10n-english will do (they usually).

Btw. I saw that you use po4a. Are you really intending for localizations
to lintian tags? 

Thanks & Greetings

             Helge

-- 
      Dr. Helge Kreutzmann                     debian@helgefjell.de
           Dipl.-Phys.                   http://www.helgefjell.de/debian.php
        64bit GNU powered                     gpg signed mail preferred
           Help keep free software "libre": http://www.ffii.de/

Attachment: signature.asc
Description: Digital signature


Reply to: