[lintian] 01/01: c/control-file: Flag directories as "not-a-file"
This is an automated email from the git hooks/post-receive script.
nthykier pushed a commit to branch master
in repository lintian.
commit 73bf16954162432db84bd73007eab439f598271a
Author: Niels Thykier <niels@thykier.net>
Date: Thu Mar 20 20:38:56 2014 +0100
c/control-file: Flag directories as "not-a-file"
In the early days, there was sometimes a "root" dir entry and other
times not. To work around that, the test also ignored dir entries.
However, now that the index never includes the "root" dir, the work
around is now obsolete.
Signed-off-by: Niels Thykier <niels@thykier.net>
---
checks/control-files.pm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/checks/control-files.pm b/checks/control-files.pm
index 4ee1fa8..af81bef 100644
--- a/checks/control-files.pm
+++ b/checks/control-files.pm
@@ -45,10 +45,8 @@ sub run {
my ($owner, $operm, $experm);
# the control.tar.gz should only contain files (and the "root"
- # dir, but that /should/ the "empty file" case in the beginning of
- # the loop) In any event, allow directories just in case - the
- # check here is mostly to catch symlinks (and "devices" etc.)
- if (not($file->is_regular_file or $file->is_dir)) {
+ # dir, but that is excluded from the index)
+ if (not $file->is_regular_file) {
tag 'control-file-is-not-a-file', $file;
# Doing further checks is probably not going to yield anything
# remotely useful.
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: