Bug#741346: lintian: check the name of modules config in /etc/pkcs11/modules

[Raphael Geissert <geissert@debian.org>]

Package: lintian
Version: 2.5.21
Tags: patch
Severity: wishlist

Hi,

Submitting as a bug for it to be reviewed and, if somebody beats me to
it, writing a a test case.

An example of a package triggering the warning by p11-kit (from jessie
or wheezy-bpo) is wheezy's gnome-keyring.

Cheers,

-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net

From 1e197a7baf40d1e7c5874cf02335af4c53f8844d Mon Sep 17 00:00:00 2001
From: Raphael Geissert <geissert@debian.org>
Date: Tue, 11 Mar 2014 11:39:44 +0100
Subject: [PATCH] Check for the naming convention of etc/pkcs11/modules files

---
 checks/files.desc |   11 +++++++++++
 checks/files.pm   |    5 +++++
 2 files changed, 16 insertions(+)

diff --git a/checks/files.desc b/checks/files.desc
index 760f86a..604610d 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -1448,3 +1448,14 @@ Info: The given file is in PATH but consists of non-ASCII characters.
  .
  Note that Lintian may be unable to display the filename accurately.
  Unprintable characters may have been replaced.
+
+Tag: incorrect-naming-of-pkcs11-module
+Severity: important
+Certainty: certain
+Info: This package ships a PKCS#11 module configuration file under
+ <tt>/etc/pkcs11/modules</tt>, but its naming doesn't conform to what
+ <tt>p11-kit</tt> expects.  Files in that directory should respect the
+ following convention, case insensitive: [a-z0-9][a-z0-9_.-]*.module
+ .
+ p11-kit currently warns on every file that does not follow the
+ convention and may ignore them in the future.
diff --git a/checks/files.pm b/checks/files.pm
index a3fda48..2276108 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -480,6 +480,11 @@ sub run {
                     close($fd);
                 }
             }
+            # ---------------- /etc/pkcs11/modules
+            elsif ($file =~ m,^etc/pkcs11/modules/\S,
+                  && $file !~ m,^etc/pkcs11/modules/[a-z0-9][a-z0-9_.-]*\.module$,i) {
+                tag 'incorrect-naming-of-pkcs11-module', $file;
+            }
             # ---------------- /etc/rc.d && /etc/rc?.d
             elsif ( $type ne 'udeb'
                 and $file =~ m,^etc/rc(?:\d|S)?\.d/\S,
-- 
1.7.10.4