[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.11-203-g4cad6b0



The following commit has been merged in the master branch:
commit 4cad6b0abbb839f8d6a16153e5eec1930145d30e
Author: Niels Thykier <niels@thykier.net>
Date:   Sat Mar 30 13:55:25 2013 +0100

    Enable and comply with perlcritic UnusedVariables policy
    
    ... also add UseStrict and UseWarnings, which we already comply with
    as well (though UseStrict sound like a duplicate of our strict.t
    check).
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/.perlcriticrc b/.perlcriticrc
index 5b66434..cced836 100644
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -8,8 +8,8 @@ severity = 1
 # Work based on a whitelist
 only = 1
 # Our whitelist (ignores severity):
-include = ExplicitReturnUndef GlobFunction NegativeIndices PrivateVars UselessInitialization MatchVars NumberSeparators NullStatements LongChainsOfMethodCalls UseStrict UseWarnings EndWithOne ConditionalUseStatements PackageMatchesPodName JoinedReadline UnreachableCode TrailingWhitespace InterpolationOfLiterals ImplicitNewlines CommaSeparatedStatements
-#include = MixedBooleanOperators InteractiveTest UpperCaseHeredoc UnusedVariables ReusedNames PackageVars ConditionalDeclarations UseStrict UseWarnings SingleCharAlternation UnusedCapture FixedStringMatches EndWithOne ConditionalUseStatements TwoArgOpen QuotedWordLists
+include = ExplicitReturnUndef GlobFunction NegativeIndices PrivateVars UselessInitialization MatchVars NumberSeparators NullStatements LongChainsOfMethodCalls UseStrict UseWarnings EndWithOne ConditionalUseStatements PackageMatchesPodName JoinedReadline UnreachableCode TrailingWhitespace InterpolationOfLiterals ImplicitNewlines CommaSeparatedStatements UseStrict UseWarnings UnusedVariables
+#include = MixedBooleanOperators InteractiveTest UpperCaseHeredoc ReusedNames PackageVars ConditionalDeclarations SingleCharAlternation UnusedCapture FixedStringMatches EndWithOne ConditionalUseStatements TwoArgOpen QuotedWordLists
 
 # If you want to try some other stuff, uncomment the following
 # (exclude is an incomplete list of things we probably won't change)
diff --git a/frontend/lintian b/frontend/lintian
index 2457075..0a79e5b 100755
--- a/frontend/lintian
+++ b/frontend/lintian
@@ -118,11 +118,9 @@ my $checks;
 my $check_tags;
 my $dont_check;
 my @unpack_info;
-my $cwd;
 my $exit_code = 0;
 my $LAB;
 
-my %check_abbrev;
 my %extra_unpack;
 my %unpack_options;
 my @auto_remove = ();
diff --git a/frontend/lintian-info b/frontend/lintian-info
index 6afa1c7..997e76a 100755
--- a/frontend/lintian-info
+++ b/frontend/lintian-info
@@ -124,7 +124,6 @@ while (<>) {
     s,</span>,,g;
 
     my $tag;
-    my $type;
     if ($annotate) {
         my $tagdata;
         next unless m/^(?:                         # start optional part
diff --git a/lib/Lintian/Collect/Binary.pm b/lib/Lintian/Collect/Binary.pm
index 745daf8..5039a78 100644
--- a/lib/Lintian/Collect/Binary.pm
+++ b/lib/Lintian/Collect/Binary.pm
@@ -336,7 +336,7 @@ sub objdump_info {
     return $self->{objdump_info} if exists $self->{objdump_info};
     my $objf = $self->lab_data_path ('objdump-info.gz');
     my %objdump_info;
-    my ($dynsyms, $file);
+    my $file;
     local $_;
     my $fd = open_gz ($objf)
         or fail "cannot open $objf: $!";
diff --git a/lib/Lintian/Processable.pm b/lib/Lintian/Processable.pm
index 35a4103..5d95f6f 100644
--- a/lib/Lintian/Processable.pm
+++ b/lib/Lintian/Processable.pm
@@ -121,7 +121,6 @@ sub new_from_metadata {
         $self->{'pkg_arch'} = 'source';
         if (not exists $self->{'pkg_path'}) {
             my $fn = delete $self->{'files'};
-            my $dsc;
             my $dir = delete $self->{'directory'};
             $dir .= '/' if defined $dir;
             $dir //= '';
diff --git a/lib/Lintian/Tags.pm b/lib/Lintian/Tags.pm
index 2340272..08551a1 100644
--- a/lib/Lintian/Tags.pm
+++ b/lib/Lintian/Tags.pm
@@ -537,7 +537,6 @@ sub file_overrides {
             my ($opkg_name, $archlist, $opkg_type, $tagdata) = ($1, $2, $3, $4);
             my ($tag, $extra) = split(m/ /o, $tagdata, 2);
             my $tagover;
-            my $com;
             my $data;
             if ($opkg_type and $opkg_type ne $info->{type}) {
                 tag 'malformed-override',
diff --git a/lib/Lintian/Unpacker.pm b/lib/Lintian/Unpacker.pm
index 571d677..4fd5896 100644
--- a/lib/Lintian/Unpacker.pm
+++ b/lib/Lintian/Unpacker.pm
@@ -474,7 +474,6 @@ sub process_tasks {
         while (my ($pid, $job_data) = wait_any ($running_jobs, $nohang)) {
             my $status = $?;
             my ($cs, $cmap, $lpkg) = @$job_data;
-            my $res;
             my $procid = $lpkg->identifier;
 
             $coll_hook->($lpkg, 'finish', $cs, $pid, $status)

-- 
Debian package checker


Reply to: