[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.11-205-gee3b0de



The following commit has been merged in the master branch:
commit ee3b0deb513c6bef10ee789efa7cc6546ac4363e
Author: Niels Thykier <niels@thykier.net>
Date:   Sat Mar 30 15:49:40 2013 +0100

    c/debian-src-dir: Use 3-arg open
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/.perlcriticrc b/.perlcriticrc
index bbf84de..1003273 100644
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -8,8 +8,8 @@ severity = 1
 # Work based on a whitelist
 only = 1
 # Our whitelist (ignores severity):
-include = ExplicitReturnUndef GlobFunction NegativeIndices PrivateVars UselessInitialization MatchVars NumberSeparators NullStatements LongChainsOfMethodCalls UseStrict UseWarnings EndWithOne ConditionalUseStatements PackageMatchesPodName JoinedReadline UnreachableCode TrailingWhitespace InterpolationOfLiterals ImplicitNewlines CommaSeparatedStatements UseStrict UseWarnings UnusedVariables UnusedCapture
-#include = MixedBooleanOperators InteractiveTest UpperCaseHeredoc ReusedNames PackageVars ConditionalDeclarations SingleCharAlternation FixedStringMatches EndWithOne ConditionalUseStatements TwoArgOpen QuotedWordLists
+include = ExplicitReturnUndef GlobFunction NegativeIndices PrivateVars UselessInitialization MatchVars NumberSeparators NullStatements LongChainsOfMethodCalls UseStrict UseWarnings EndWithOne ConditionalUseStatements PackageMatchesPodName JoinedReadline UnreachableCode TrailingWhitespace InterpolationOfLiterals ImplicitNewlines CommaSeparatedStatements UseStrict UseWarnings UnusedVariables UnusedCapture TwoArgOpen
+#include = MixedBooleanOperators InteractiveTest UpperCaseHeredoc ReusedNames PackageVars ConditionalDeclarations SingleCharAlternation FixedStringMatches EndWithOne ConditionalUseStatements QuotedWordLists
 
 # If you want to try some other stuff, uncomment the following
 # (exclude is an incomplete list of things we probably won't change)
diff --git a/checks/debian-source-dir b/checks/debian-source-dir
index 7a391d3..35d96da 100644
--- a/checks/debian-source-dir
+++ b/checks/debian-source-dir
@@ -48,7 +48,7 @@ if ( ! -l "$dsrc/format" && -e "$dsrc/format") {
 }
 
 if ( ! -l "$dsrc/git-patches" && -s "$dsrc/git-patches") {
-    open (GITPATCHES, "$dsrc/git-patches")
+    open GITPATCHES, '<', "$dsrc/git-patches"
         or fail("cannot open debian/source/git-patches: $!");
     if (grep !/^\s*+#|^\s*+$/o, <GITPATCHES>) {
         my $dpseries = $info->debfiles('patches/series');
@@ -58,7 +58,7 @@ if ( ! -l "$dsrc/git-patches" && -s "$dsrc/git-patches") {
             if (! -r $dpseries ) {
                 tag 'git-patches-not-exported';
             } else {
-                open (DEBSERIES, $dpseries)
+                open DEBSERIES, '<', $dpseries
                     or fail("cannot open debian/patches/series: $!");
                 my $comment_line = <DEBSERIES>;
                 my $count = grep !/^\s*+\#|^\s*+$/o, <DEBSERIES>;

-- 
Debian package checker


Reply to: