[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#663038: marked as done (lintian: [PATCH] In package-name-doesnt-match-sonames description, change sed to awk example)



Your message dated Mon, 22 Jul 2013 14:28:44 +0200
with message-id <51ED257C.8080504@thykier.net>
and subject line Re: Bug#663038: lintian: [PATCH] In package-name-doesnt-match-sonames description, change sed to awk example
has caused the Debian Bug report #663038,
regarding lintian: [PATCH] In package-name-doesnt-match-sonames description, change sed to awk example
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
663038: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=663038
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.5.5
Severity: wishlist
Tags: patch

Please see if this suggestion to use simpler awk solution for double
sed call in the example of package-name-doesnt-match-sonames
description would be useful.

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (990, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-1-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-- no debconf information
>From 5625b5eabad4d97095c736cee6770fb977a7f92a Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto@cante.net>
Date: Thu, 8 Mar 2012 02:20:31 -0500
Subject: [PATCH] In package-name-doesnt-match-sonames description, change sed
 to awk example
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


Signed-off-by: Jari Aalto <jari.aalto@cante.net>
---
 checks/binaries.desc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/checks/binaries.desc b/checks/binaries.desc
index 4e0ad1e..c523f77 100644
--- a/checks/binaries.desc
+++ b/checks/binaries.desc
@@ -145,7 +145,8 @@ Info: The package name of a library package should usually reflect
  the soname of the included library. The package name can determined
  from the library file name with the following code snippet:
  .
-  $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n -e's/^[[:space:]]*SONAME[[:space:]]*//p' | sed -e's/\([0-9]\)\.so\./\1-/; s/\.so\.//'
+  $ objdump -p /path/to/libfoo-bar.so.1.2.3 |
+    awk '/SONAME/ {sub("[.]so[.]",""); sub("[.][0-9.]+",""); print $2; exit}'
 
 Tag: binary-with-bad-dynamic-table
 Severity: serious
-- 
1.7.9.1


--- End Message ---
--- Begin Message ---
On 2012-05-27 10:42, Niels Thykier wrote:
> [...]
> 
> An example: libgstphotography-0.10.so.23
> 
> Here your awk code gives:
>   libgstphotography-0
> and the sed code gives:
>   libgstphotography-0.10-23
> 
> 
> Tagging wontfix as the attached patch does not work and I am not
> convinced replacement has any significant value.
> 
> ~Niels
> 

Taking the liberty of closing this now.

~Niels

--- End Message ---

Reply to: