[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.14-78-g8fd63ce



The following commit has been merged in the master branch:
commit 4be986b4ef8e6eb9e861e824bcc2a76572744f2f
Author: Mathieu Parent <math.parent@gmail.com>
Date:   Wed Jul 10 10:49:59 2013 +0200

    Check for missing bdeps on PECL packages
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/checks/phppear.desc b/checks/phppear.desc
index e8e800e..bd174ea 100644
--- a/checks/phppear.desc
+++ b/checks/phppear.desc
@@ -35,6 +35,12 @@ Severity: normal
 Certainty: possible
 Info: The package requires a newer pkg-php-tools for a specific feature.
 
+Tag: pecl-package-requires-build-dependency
+Severity: normal
+Certainty: possible
+Info: The package is a PECL package but its control file doesn't have
+ php5-dev or dh-php5 as a build dependency.
+
 Tag: composer-package-without-pkg-php-tools-builddep
 Severity: normal
 Certainty: possible
diff --git a/checks/phppear.pm b/checks/phppear.pm
index 995da81..6f4edf6 100644
--- a/checks/phppear.pm
+++ b/checks/phppear.pm
@@ -89,6 +89,12 @@ sub run {
         }
         close($package_xml_fd);
         if ($package_type eq 'extsrc') { # PECL package
+            if (!$bdepends->implies('php5-dev')) {
+                tag 'pecl-package-requires-build-dependency', 'php5-dev';
+            }
+            if (!$bdepends->implies('dh-php5')) {
+                tag 'pecl-package-requires-build-dependency', 'dh-php5';
+            }
             if (!$bdepends->implies('pkg-php-tools (>= 1.5~)')) {
                 tag 'pear-package-feature-requires-newer-pkg-php-tools',
                     '(>= 1.5~)', 'for PECL support';
diff --git a/t/tests/phppear-pear/desc b/t/tests/phppear-pear/desc
index 17a40cd..19139fd 100644
--- a/t/tests/phppear-pear/desc
+++ b/t/tests/phppear-pear/desc
@@ -5,4 +5,5 @@ Description: phppear tests for PEAR packages
 Test-For:
  pear-package-but-missing-dependency
  pear-package-feature-requires-newer-pkg-php-tools
+ pecl-package-requires-build-dependency
 Type: non-native
diff --git a/t/tests/phppear-pear/tags b/t/tests/phppear-pear/tags
index f58d6d4..88c5cf8 100644
--- a/t/tests/phppear-pear/tags
+++ b/t/tests/phppear-pear/tags
@@ -4,3 +4,5 @@ W: phppear-pear source: pear-package-but-missing-dependency Recommends
 W: phppear-pear source: pear-package-feature-requires-newer-pkg-php-tools (>= 1.4~) for package2.xml
 W: phppear-pear source: pear-package-feature-requires-newer-pkg-php-tools (>= 1.5~) for PECL support
 W: phppear-pear source: pear-package-feature-requires-newer-pkg-php-tools (>= 1~) for package name overrides
+W: phppear-pear source: pecl-package-requires-build-dependency dh-php5
+W: phppear-pear source: pecl-package-requires-build-dependency php5-dev

-- 
Debian package checker


Reply to: