[SCM] Debian package checker branch, master, updated. 2.5.14-78-g8fd63ce
The following commit has been merged in the master branch:
commit 0b4c99b3fefd777d366add895172cee26d9d82ef
Author: Mathieu Parent <math.parent@gmail.com>
Date: Wed Jul 10 14:28:37 2013 +0200
Check for ${phppear:description} and ${phppear:summary}
Signed-off-by: Niels Thykier <niels@thykier.net>
diff --git a/checks/phppear.desc b/checks/phppear.desc
index bd174ea..c063bcd 100644
--- a/checks/phppear.desc
+++ b/checks/phppear.desc
@@ -30,6 +30,12 @@ Certainty: possible
Info: The package is a PEAR package but its control file doesn't have
${phppear:Debian-Depends} in Depends or ${phppear:Debian-Recommends}.
+Tag: pear-package-not-using-substvar
+Severity: normal
+Certainty: possible
+Info: The package is a PEAR package but its control file doesn't have
+ ${phppear:summary} or ${phppear:description} in its description fields.
+
Tag: pear-package-feature-requires-newer-pkg-php-tools
Severity: normal
Certainty: possible
diff --git a/checks/phppear.pm b/checks/phppear.pm
index 6f4edf6..5714fc5 100644
--- a/checks/phppear.pm
+++ b/checks/phppear.pm
@@ -55,6 +55,14 @@ sub run {
if (!$breaks->implies('${phppear:Debian-Breaks}')) {
tag 'pear-package-but-missing-dependency', 'Breaks';
}
+ # Checking description
+ my $description = $info->binary_field($binary, 'description');
+ if ($description !~ /\$\{phppear:summary\}/) {
+ tag 'pear-package-not-using-substvar', '${phppear:summary}'
+ }
+ if ($description !~ /\$\{phppear:description\}/) {
+ tag 'pear-package-not-using-substvar', '${phppear:description}'
+ }
# Checking overrides
my $overrides = $info->debfiles('pkg-php-tools-overrides');
if (-f $overrides) {
diff --git a/t/tests/phppear-pear/desc b/t/tests/phppear-pear/desc
index 19139fd..8e72e0b 100644
--- a/t/tests/phppear-pear/desc
+++ b/t/tests/phppear-pear/desc
@@ -5,5 +5,6 @@ Description: phppear tests for PEAR packages
Test-For:
pear-package-but-missing-dependency
pear-package-feature-requires-newer-pkg-php-tools
+ pear-package-not-using-substvar
pecl-package-requires-build-dependency
Type: non-native
diff --git a/t/tests/phppear-pear/tags b/t/tests/phppear-pear/tags
index 88c5cf8..d0b3852 100644
--- a/t/tests/phppear-pear/tags
+++ b/t/tests/phppear-pear/tags
@@ -4,5 +4,7 @@ W: phppear-pear source: pear-package-but-missing-dependency Recommends
W: phppear-pear source: pear-package-feature-requires-newer-pkg-php-tools (>= 1.4~) for package2.xml
W: phppear-pear source: pear-package-feature-requires-newer-pkg-php-tools (>= 1.5~) for PECL support
W: phppear-pear source: pear-package-feature-requires-newer-pkg-php-tools (>= 1~) for package name overrides
+W: phppear-pear source: pear-package-not-using-substvar ${phppear:description}
+W: phppear-pear source: pear-package-not-using-substvar ${phppear:summary}
W: phppear-pear source: pecl-package-requires-build-dependency dh-php5
W: phppear-pear source: pecl-package-requires-build-dependency php5-dev
--
Debian package checker
Reply to: