Bug#639292: lintian: --color=html does not close '<p>' - breaks xhtml (lintian.d.o)

[Niels Thykier <niels@thykier.net>]

On 2011-08-25 21:15, Adam D. Barratt wrote:
> On Thu, 2011-08-25 at 19:15 +0200, Niels Thykier wrote:
>> Notice how none of the "<p>" tags are closed; given xhtml is
>> xml-based, all tags must be closed or the document will be malformed.
> [...]
>> 	    push(@o,"<p>$_\n");
>> [...]
>>
>> becomes
>>
>> [...]
>> 	    push(@o,"<p>$_</p>\n");
>> [...]
>> but I do not fully understand the code there.
> 
> It's a fairly uncomplicated function, other than keeping track of
> whether we're trying to display literal text - e.g the two examples on
> http://lintian.debian.org/tags/binary-or-shlib-defines-rpath.html - and
> your change looks sane enough to me, fwiw.

Okay, I applied it and cherry-picked it to lintian.d.o; the w3.org
validator seems to approve[1], so that's always something.  :)

> 
> While we're on the subject of that page, it would be nice to do
> something about the <pre> -> <p> spacing, as at least in Iceweasel here
> there's a large gap after each of the gcc lines.
> 

I agree, but I think we need someone to mess with the .css file then.
The resulting source is:

"""
    <p>To fix this problem, look for link lines like:</p>

    <pre>
        gcc test.o -o test -Wl,--rpath,/usr/local/lib
    </pre> <p>or</p>

    <pre>
        gcc test.o -o test -R/usr/local/lib
    </pre> <p>and remove the <tt>-Wl,--rpath</tt> or [...]</p>
"""

I see nothing here in the html that "adds" unneeded line breaks.  On a
related note; I am not good with .css.

> Regards,
> 
> Adam


~Niels

[1]
http://validator.w3.org/check?uri=http%3A%2F%2Flintian.debian.org%2Ftags%2Fbinary-or-shlib-defines-rpath.html&charset=%28detect+automatically%29&doctype=Inline&ss=1&group=0&verbose=1&user-agent=W3C_Validator%2F1.2