Bug#639292: lintian: --color=html does not close '<p>' - breaks xhtml (lintian.d.o)

[Niels Thykier <niels@thykier.net>]

Package: lintian
Version: 2.5.2
Severity: minor

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi

Source snippet from http://lintian.debian.org/tags/arch-dep-package-has-big-usr-share.html

Notice how none of the "<p>" tags are closed; given xhtml is xml-based, all tags must be
closed or the document will be malformed.

"""
  <blockquote class="type-I">
    <p>The package has a significant amount of architecture-independent data
    (over 4MB, or over 2MB and more than 50% of the package) in
    <tt>/usr/share</tt> but is an architecture-dependent package. This is
    wasteful of mirror space and bandwidth since it means distributing
    multiple copies of this data, one for each architecture.
    
    <p>If the data in <tt>/usr/share</tt> is not architecture-independent,
    this is a Policy violation that should be fixed by moving the data
    elsewhere (usually <tt>/usr/lib</tt>).
    
    <p>Refer to <a
    href="http://www.debian.org/doc/developers-reference/";>Debian
    Developer's Reference</a> section 6.7.5 (<a
    href="http://www.debian.org/doc/developers-reference/best-pkging-practices.html#bpp-archindepdata";>Architecture-independent
    data</a>) for details.
    
    <p>Severity: wishlist, Certainty: certain
    
    <p>Check: huge-usr-share, Type: binary

  </blockquote>
"""

This seems to be caused by "dtml_to_html" in lib/Text_utils.pm;  it seems to work
if
[...]
	    push(@o,"<p>$_\n");
[...]

becomes

[...]
	    push(@o,"<p>$_</p>\n");
[...]
but I do not fully understand the code there.

~Niels


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJOVoM+AAoJEAVLu599gGRCYaIP/RJ/ZTVK9DzG2UM1SkB1xoU3
34z1ADa6jigQwdiQ5OEBCveI/bHJQEpmE4JgeuQe3inD2ha+PGOOIoTrsRpJZYnZ
ELGROJO578so0eIIzLANSlH7PViD/Gkd/67ZQ+2d0BqJjopugkIZrXj5GdQj/XwC
h/IG7xL+z6FNp5Cp6GgsLT9va9G+SJo2WeuA9uhlDDNyZiZJn+5iZqJ1wo8Zl499
+Rs4agMeLfha0VJC3AvxTqB7BRB4krq4cKnS5Uh9qBsOI+OIBP1EZKcjTaVai9fj
jcakc3z97Aav0cMY5doxnMSrIBuBZ4AF5u+tfKg+hvzm6DlOEXY1MUl7hofVOKaY
Og7UxFV6k3WgmgfM0ggpRgraKjIJNrwFCz84eCyiQ6YzLbg7tn3H0Rj4BduH3CZ+
30ReKEnbgBMC7eZ0Z5sSd/R61lpMfFwDQNJ6hCOJembDRQR6hLw5lh/3qMPbXV0V
LUzb2j2ESNUeG0TJeIYDD5rRKUbiadZ7mFZPXqcM3J5y9xunWQDmEzlzTkEWX1GI
RqTdJCJmIe+YvpPrxF7ECh+Y9L4NXjXK9GZ48+jugg+gMXQzK22+YA4pU0tTFMPa
HX/IFcjeRFN+7VsWTb4zSZaquy+e93NWj9pnpfgilkPxCVQmPtVgjw5D9rDeiml1
OfP3w92h4mXbU5Gh0CDJ
=W3QN
-----END PGP SIGNATURE-----