[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.5.2-127-gb96beb0



The following commit has been merged in the master branch:
commit b96beb0e3b046582a4e5d7deec09b1b0caeab3d7
Author: Niels Thykier <niels@thykier.net>
Date:   Sat Sep 10 08:41:23 2011 +0200

    Added check for B-D on libdbX.Y{,$stuff}-dev

diff --git a/checks/fields b/checks/fields
index 1fbb0e1..2de3253 100644
--- a/checks/fields
+++ b/checks/fields
@@ -775,10 +775,14 @@ if ($type eq 'source') {
 						}
 					}
 
-					if($d_pkg =~ m/openjdk-\d+-doc/o or $d_pkg eq 'classpath-doc'){
+					if ($d_pkg =~ m/^openjdk-\d+-doc$/o or $d_pkg eq 'classpath-doc'){
 					    tag 'build-depends-on-specific-java-doc-package', $d_pkg;
 					}
 
+					if ($d_pkg =~ m/^libdb\d+\.\d+.*-dev$/o and &$is_dep_field($field)) {
+					    tag 'build-depends-on-versioned-berkeley-db', "$field:$d_pkg";
+					}
+
 					tag 'conflicting-negation-in-source-relation', "$field: $part_d_orig"
 					    unless (not $d_arch or $d_arch->[1] == 0 or $d_arch->[1] eq @{ $d_arch->[0] });
 
diff --git a/checks/fields.desc b/checks/fields.desc
index 745539f..b7f232b 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1051,3 +1051,28 @@ Certainty: certain
 Info: Documentation packages usually shouldn't carry anything that requires
  recompiling on various architectures, in order to save space on mirrors.
 
+Tag: build-depends-on-versioned-berkeley-db
+Severity: normal
+Certainty: possible
+Info: The package build-depends on a versioned development package of
+ Berkeley DB (libdbX.Y-dev) instead of versionless package
+ (libdb-dev).  Unfortunately this prevents binNMUs when default
+ Berkeley DB version changes.
+ .
+ Unless the package absolutely have to depend on specific Berkeley DB
+ version, it should build-depends on libdb-dev. For more information
+ on the upgrade process, please see the references.
+ .
+ The package can usually be made Berkeley DB version agnostic by the
+ following steps:
+ .
+  1. note the version of Berkeley DB used to compile the package on build time
+  2. on first install copy the used version to active version
+  3. on upgrades compare the versions and if they differ do the upgrade procedure
+ .
+ If you are unsure you can contact Berkeley DB maintainer, who would be
+ glad to help.
+ .
+ Should the package have a legitimate reason for using the versioned development
+ package, please add an override.
+Ref: http://download.oracle.com/docs/cd/E17076_02/html/upgrading/upgrade_process.html
diff --git a/debian/changelog b/debian/changelog
index dcaf2c9..48e6ead 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -85,6 +85,10 @@ lintian (2.5.3) UNRELEASED; urgency=low
     + [JW,NT] If superfluous-clutter-in-homepage has been emitted,
       ignore the surrounding "<>" for the rest of the homepage checks.
       (Closes: #640947)
+    + [NT] Added check for Build-Depending on libdbX.Y-dev (and related
+      packages.  Most packages should be able to use unversioned -dev
+      packages.  Thanks to Ondřej Surý for the report and the initial
+      tag description.  (Closes: #624434)
   * checks/{filename-length,rules}.desc:
     + [NT] Improved the descriptions of some tags.  (Closes: #639018)
   * checks/files{,.desc}:
diff --git a/t/COVERAGE b/t/COVERAGE
index 1555f42..4d99fe7 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,5 +1,5 @@
-Last generated 2011-09-08
-Coverage: 720/935 (77.01%), w. legacy tests: 842/935 (90.05%)
+Last generated 2011-09-10
+Coverage: 721/936 (77.03%), w. legacy tests: 843/936 (90.06%)
 
 The following tags are not tested by the test suite:
 
diff --git a/t/tests/fields-build-depends-general/debian/debian/control.in b/t/tests/fields-build-depends-general/debian/debian/control.in
index c302eae..bd807fc 100644
--- a/t/tests/fields-build-depends-general/debian/debian/control.in
+++ b/t/tests/fields-build-depends-general/debian/debian/control.in
@@ -8,7 +8,7 @@ Build-Depends: debhelper (>= 7.0.50~), bd-conflict, revision-1 (>= 1.0-1),
  xorg-dev, java-propose-classpath, python3.2-dev, foo [all],
  bar [i386 any], baz [source i3!86], baz [i386 !amd64],
  other-pkg [kfreebsd-any], yet-another [any-powerpc],
- packaging-dev
+ packaging-dev, libdb5.1++-dev, libdb5.1-java-dev
 Build-Conflicts: bd-conflict
 
 Package: {$srcpkg}
diff --git a/t/tests/fields-build-depends-general/desc b/t/tests/fields-build-depends-general/desc
index df21b30..b8b7a1b 100644
--- a/t/tests/fields-build-depends-general/desc
+++ b/t/tests/fields-build-depends-general/desc
@@ -11,6 +11,7 @@ Test-For:
  build-depends-on-non-build-package
  build-depends-on-obsolete-package
  build-depends-on-python-dev-with-no-arch-any
+ build-depends-on-versioned-berkeley-db
  conflicting-negation-in-source-relation
  depends-on-build-essential-package-without-using-version
  depends-on-packaging-dev
diff --git a/t/tests/fields-build-depends-general/tags b/t/tests/fields-build-depends-general/tags
index 046a2a1..e08e24d 100644
--- a/t/tests/fields-build-depends-general/tags
+++ b/t/tests/fields-build-depends-general/tags
@@ -12,4 +12,6 @@ E: fields-build-depends-general source: invalid-arch-string-in-source-relation s
 I: fields-build-depends-general source: ored-build-depends-on-obsolete-package build-depends: xlibmesa-gl-dev
 W: fields-build-depends-general source: build-depends-on-1-revision build-depends: revision-1 (>= 1.0-1)
 W: fields-build-depends-general source: build-depends-on-python-dev-with-no-arch-any
+W: fields-build-depends-general source: build-depends-on-versioned-berkeley-db build-depends:libdb5.1++-dev
+W: fields-build-depends-general source: build-depends-on-versioned-berkeley-db build-depends:libdb5.1-java-dev
 W: fields-build-depends-general source: depends-on-packaging-dev build-depends

-- 
Debian package checker


Reply to: