Re: Fixing indentation in our source files
Niels Thykier <niels@thykier.net> writes:
> Jakub pointed out that a some of our source files have inconsistent. He
> also produced the attached document that visualize the different
> indentation styles in our code ("Tttttttt" is one tab and "s" is a
> space).
> So would anyone object if I sed s/\t/ /g'ed our code (with manual
> fixup where needed). It could (and probably will) give issues applying
> any existing patches (on the BTS).
I'm always of two minds about this kind of thing since it makes any
merging or patch application across the change a huge pain, but I like
having consistency. I was mostly leaving things alone except when we
mostly rewrote a file, but that doesn't get us anywhere particularly
quickly.
If we're going to do a mass indentation fix and take the hit for that, it
would be tempting to standardize on an identation level as well. I think
we have some files that are using an eight-space indent.
--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
Reply to: