Bug#624201: [PATCH] simple-patchsys.mk is deprecated by source format 3.0 (quilt)
Signed-off-by: Luk Claes <luk@debian.org>
---
checks/rules | 5 +++++
checks/rules.desc | 7 +++++++
debian/changelog | 3 +++
3 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/checks/rules b/checks/rules
index 2ac1d3f..0b8a5f9 100644
--- a/checks/rules
+++ b/checks/rules
@@ -179,6 +179,11 @@ while (<RULES>) {
tag 'debian-rules-sets-DH_COMPAT', "line $.";
}
+ # Check for deprecated use of simple-patchsys.mk
+ if (/^\s*include\s*\/usr\/share\/cdbs\/1\/rules\/simple-patchsys\.mk/) {
+ tag 'debian-rules-uses-simple-patchsys', "line $.";
+ }
+
# Check for problems that can occur anywhere in debian/rules.
if (/\$[\(\{]PWD[\)\}]/) {
tag 'debian-rules-uses-pwd', "line $.";
diff --git a/checks/rules.desc b/checks/rules.desc
index af5b25e..0e00036 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -60,6 +60,13 @@ Info: The <tt>debian/rules</tt> file for this package does not provide
These targets will be required by policy in the future, so should be
added to prevent future breakage.
+Tag: debian-rules-uses-simple-patchsys
+Severity: normal
+Certainty: certain
+Info: The <tt>debian/rules</tt> file for this package appears to include
+ /usr/share/cdbs/1/rules/simple-patchsys.mk. This makefile is deprecated
+ by source format 3.0 (quilt).
+
Tag: debian-rules-uses-pwd
Severity: normal
Certainty: certain
diff --git a/debian/changelog b/debian/changelog
index d2c4d3b..4b7cfab 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,7 @@ lintian (2.5.2) UNRELEASED; urgency=low
- package-has-long-file-name
- source-package-component-has-long-file-name
- upstart-job-in-etc-init.d-not-registered-via-update-rc.d
+ - debian-rules-uses-simple-patchsys
* checks/binaries:
+ [NT] Added lib/${MULTIARCH_DIR} to the list of paths to
@@ -51,6 +52,8 @@ lintian (2.5.2) UNRELEASED; urgency=low
false negatives of missing targets. Thanks to
Jakub Wilk for the suggestion and the initial makefile
list. (Closes: #631711)
+ + [LC] Warn about including simple-patchsys as it is
+ deprecated by source format 3.0 (quilt). (Closes: #624201)
* checks/symlinks:
+ [NT] Symlink checking extended to relative paths as well.
(Closes: #217023)
--
1.7.5.4
Reply to: