Bug#629308: [PATCH] packaging-dev should not be (build) depended on or even be recommended

[Luk Claes <luk@debian.org>]

Signed-off-by: Luk Claes <luk@debian.org>
---
 checks/fields      |    6 ++++++
 checks/fields.desc |    6 ++++++
 debian/changelog   |    3 +++
 3 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/checks/fields b/checks/fields
index 4435f66..b23760c 100644
--- a/checks/fields
+++ b/checks/fields
@@ -650,6 +650,9 @@ if (($type eq 'binary') || ($type eq 'udeb')) {
 				tag 'package-depends-on-an-x-font-package', "$field: $part_d_orig"
 				    if ($field =~ /^(pre-)?depends$/ && $d_pkg =~ /^xfont.*/ && $d_pkg ne 'xfonts-utils' && $d_pkg ne 'xfonts-encodings');
 
+				tag 'depends-on-packaging-dev', "$field: $part_d_orig"
+				    if (($field =~ /^(pre-)?depends$/ || $field =~ /^recommends$/) && $d_pkg =~ /^packaging-dev$/);
+
 				tag 'needlessly-depends-on-awk', $field
 				    if ($d_pkg eq 'awk' && ! $d_version->[0] && &$is_dep_field($field) && $pkg ne 'base-files');
 
@@ -800,6 +803,9 @@ if ($type eq 'source') {
 					tag 'build-depends-on-build-essential', $field
 					    if ($d_pkg eq 'build-essential');
 
+					tag 'depends-on-packaging-dev', $field
+					    if ($d_pkg eq 'packaging-dev');
+
 					tag 'depends-on-build-essential-package-without-using-version', "$d_pkg [$field: $part_d_orig]"
 					    if ($known_build_essential{$d_pkg} && ! $d_version->[1]);
 
diff --git a/checks/fields.desc b/checks/fields.desc
index 964d0bb..7e486fb 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -863,6 +863,12 @@ Severity: important
 Certainty: certain
 Ref: policy 7.7
 
+Tag: depends-on-packaging-dev
+Info: You depend/recommend/build-depend on packaging-dev, which is
+ only a metapackage to install common packages needed for packaging.
+Severity: normal
+Certainty: certain
+
 Tag: malformed-python-version
 Severity: important
 Certainty: certain
diff --git a/debian/changelog b/debian/changelog
index 4b7cfab..a496abe 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,7 @@ lintian (2.5.2) UNRELEASED; urgency=low
       - source-package-component-has-long-file-name
       - upstart-job-in-etc-init.d-not-registered-via-update-rc.d
       - debian-rules-uses-simple-patchsys
+      - depends-on-packaging-dev
 
   * checks/binaries:
     + [NT] Added lib/${MULTIARCH_DIR} to the list of paths to
@@ -134,6 +135,8 @@ lintian (2.5.1) unstable; urgency=low
     + [NT] Allow "all" and "any" to appear together in the Architecture
       field of a .dsc file.  (Closes: #626775)
     + [NT] Added illegal-multi-arch-value.  (Closes: #616493)
+    + [LC] Warn about (build)depending/recommending on packaging-dev.
+      (Closes: #629308)
   * checks/files:
     + [NT] Fixed two misnamed udeb tags, which lead to an internal
       error if triggered.  Thanks to Guillem Jover for the report.
-- 
1.7.5.4