Bug#580789: lintian: [checks/cruft.desc] PATCH: ancient-libtool - Improve documentation
Jari Aalto <jari.aalto@cante.net> writes:
> --- a/checks/cruft.desc
> +++ b/checks/cruft.desc
> @@ -379,13 +379,19 @@ Info: The referenced file seems to be from a libtool version
> newer architectures not known to this libtool.
> .
> Please ask your upstream maintainer to re-libtoolize the
> - package or do it yourself in case there is no active upstream
> - anymore. Beware that might mean you need to update autoconf, too,
> - if you use a very old version there as well.
> + package or in case there is no active upstream, do it yourself,
> + remove old ltconfig and run:
> + .
> + libtoolize --copy --force --install
> + .
> + Note: with very old packages you may see message suggesting '...add
> + the contents of... *.m4' but do *not* follow the advice, but the last
> + line that usually suggest modifying configure.in; and rerun
> + libtoolize. Beware that might mean you need to update autoconf, too.
> .
> If you have not updated the file but fixed architecture-specific
> issues with minimal patches and verified that it builds correctly
> - please override this tag. lintian will not be able to verify that.
> + please override this tag. Lintian will not be able to verify that.
>
> Tag: source-contains-prebuilt-binary
> Severity: pedantic
I don't agree with these recommendations, but I made a different change
that will hopefully provide similar help.
diff --git a/checks/cruft.desc b/checks/cruft.desc
index ccb925f..12923a6 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -374,18 +374,27 @@ Info: The referenced file has a time stamp older than June of 2006 and the
Tag: ancient-libtool
Severity: normal
Certainty: possible
-Info: The referenced file seems to be from a libtool version
- older than 1.5.2-2. This might lead to build errors on some
- newer architectures not known to this libtool.
+Info: The referenced file seems to be from a libtool version older than
+ 1.5.2-2. This might lead to build errors on some newer architectures not
+ known to this libtool.
.
- Please ask your upstream maintainer to re-libtoolize the
- package or do it yourself in case there is no active upstream
- anymore. Beware that might mean you need to update autoconf, too,
- if you use a very old version there as well.
+ Please ask your upstream maintainer to re-libtoolize the package or do it
+ yourself if there is no active upstream. You will also need to run
+ Autoconf to regenerate the configure script. Usually it is best to do
+ this during the build by depending on autoconf, libtool, and automake if
+ it is used, and then running:
.
- If you have not updated the file but fixed architecture-specific
- issues with minimal patches and verified that it builds correctly
- please override this tag. lintian will not be able to verify that.
+ autoreconf -i --force
+ .
+ before running configure. Depending on how old the package is, this may
+ require additional modifications to <tt>configure.ac</tt> or
+ <tt>configure.in</tt> or other work. If you do this during the build,
+ determine which files it will add or update and be sure to remove those
+ files in the clean target.
+ .
+ If you have fixed architecture-specific issues with minimal patches,
+ rather than updating libtool, and verified that it builds correctly,
+ please override this tag. Lintian will not be able to verify that.
Tag: source-contains-prebuilt-binary
Severity: pedantic
--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
Reply to: