[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#588873: lintian: [new check] Warn if using 3.0 (quilt) and there is a debian-changes-xxx patch



Iain Lane <laney@ubuntu.com> writes:

> I'd like to propose a new check which is analogous to
> patch-system-but-direct-changes-in-diff but for 3.0 (quilt).

> (or perhaps this check could just be extended: thoughts?)

> Here we would look to see whether the package declares 3.0 (quilt) and
> if so, check if single-debian-patch is not set in debian/source/format
> 	and there is a debian-changes-xxx patch. If yes, spit out a warning.

> What do you think? If the consensus is that this is a good idea then
> I'll have a go at implementing.

Most of my packages intentionally have only that patch.  Maybe only
trigger it if debian/source/patch-header doesn't exist and mention that if
this is intentional, creating that file allows adding a custom header to
the generated patch explaining why this is done?  That could avoid the
numerous false positives of patch-system-but-direct-changes-in-diff and
make it less wild-guessy.

Otherwise, seems like a good idea to me.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>



Reply to: