[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#519268: lintian: same problem in mksh, but with a twist



tag 519268 patch
thanks

Russ Allbery wrote:

> Raphael Geissert writes:
>> Russ Allbery wrote:
[...]
> 
>>>> +    # find the widest regex:
>>>> +    my @matches = grep {
>>>> +                if ($wider =~ m/^$_$/) {
>>>> +                    $wider = $_;
> 
>>> Buggy if $_ evaluates to false; you need a 1; here.
> 
>> In what case would it evaluate to false? not that I'm against adding 1;
>> :)
> 
> If it starts with 0, there's some distant chance.  It's pretty unlikely, I
> agree, but it's one of those Perl gotchas that are worth being aware of.
> 

I wasn't aware of that, thanks :)

Attached mbox should do it, it even fixes a bug where the normalisation code
wasn't actually doing anything. 

Cheers,
-- 
Raphael Geissert - Debian Maintainer
www.debian.org - get.debian.net

Attachment: smart-diversions.mbox
Description: application/mbox


Reply to: