[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#519268: lintian: same problem in mksh, but with a twist



Raphael Geissert <atomo64+debian@gmail.com> writes:
> Russ Allbery wrote:

>> This has to be an array to avoid the bug fixed in HEAD anyway, so I
>> think easier to leave this a list.

> I was thinking about a different approach: keeping %removed_diversions
> but making each element an array, making the whole thing a hash of
> arrays of hashes :)

That would also work.  Thank you very much for this!  It's a way more
interesting solution than I had come up with.

>>> +    # find the widest regex:
>>> +    my @matches = grep {
>>> +                if ($wider =~ m/^$_$/) {
>>> +                    $wider = $_;

>> Buggy if $_ evaluates to false; you need a 1; here.

> In what case would it evaluate to false? not that I'm against adding 1; :)

If it starts with 0, there's some distant chance.  It's pretty unlikely, I
agree, but it's one of those Perl gotchas that are worth being aware of.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>



Reply to: