Re: couple of patches
Raphael Geissert <atomo64+debian@gmail.com> writes:
> None of these require my previous changes to be applied, but would be
> great if the others could be applied as well.
I applied the first patch. For the move of common_data, I agree that this
is an improvement over the current state, but except for %known_arches,
that data actually belongs in Lintian::Data. Could you move it there
instead? Otherwise, we'll just have to do it later and there's no point
in touching the same code twice.
I realize this will make Lintian a bit slower until we optimize
Lintian::Data further, but it's more than worth it for the maintenance
improvements of simple text files with lists instead of Perl code.
You should be able to eliminate common_data.pm entirely except for the
shells regex, which we can abstract into a Util function.
--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
Reply to: