[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#513132: lintian: No colours for pedants



Package: lintian
Version: 2.2.0
Severity: minor
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

When I run
  lintian -iI --pedantic --color=auto foo.changes
and lintian hits a tag marked as pedantic I get the following
warnings:

Use of uninitialized value $_ in split at /usr/share/perl/5.10/Term/ANSIColor.pm line 121.
Use of uninitialized value in concatenation (.) or string at /usr/share/perl/5.10/Term/ANSIColor.pm line 187.

The following trivial patch gets rid of the warnings and - even
better - makes life more colourful for pedants :)

(Please use any colour you like, I just took the first one that came
to my mind to see if it works this way.)

#v+
- --- lib/Lintian/Output.pm.orig	2009-01-26 20:31:29.000000000 +0100
+++ lib/Lintian/Output.pm	2009-01-26 20:31:52.000000000 +0100
@@ -126,7 +126,7 @@
 		  'string');
 
 # for the non-OO interface
- -my %default_colors = ( 'E' => 'red' , 'W' => 'yellow' , 'I' => 'cyan' );
+my %default_colors = ( 'E' => 'red' , 'W' => 'yellow' , 'I' => 'cyan', 'P' => 'blue' );
 
 our $GLOBAL = new Lintian::Output;
 

#v-

Cheers,
gregor

- -- System Information:
Debian Release: 5.0
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'oldstable'), (500, 'experimental'), (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.28.200901241655
Locale: LANG=C, LC_CTYPE=de_AT@euro (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash

Versions of packages lintian depends on:
ii  binutils            2.18.1~cvs20080103-7 The GNU assembler, linker and bina
ii  diffstat            1.46-1               produces graph of changes introduc
ii  dpkg-dev            1.14.24              Debian package development tools
ii  file                4.26-2               Determines file type using "magic"
ii  gettext             0.17-6               GNU Internationalization utilities
ii  intltool-debian     0.35.0+20060710.1    Help i18n of RFC822 compliant conf
ii  libipc-run-perl     0.82-1               Perl module for running processes
ii  libparse-debianchan 1.1.1-2              parse Debian changelogs and output
ii  libtimedate-perl    1.1600-9             Time and date functions for Perl
ii  liburi-perl         1.37+dfsg-1          Manipulates and accesses URI strin
ii  man-db              2.5.2-4              on-line manual pager
ii  perl [libdigest-sha 5.10.0-19            Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch            <none>     (no description available)
ii  libtext-template-perl         1.44-1.2   Text::Template perl module
ii  man-db                        2.5.2-4    on-line manual pager

- -- no debconf information

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkl+EPAACgkQOzKYnQDzz+STZgCg4TIGbpZoGwOdAy+APR0kHSsP
aPUAni+xRSePq2jdLslUK3gKXKWK9zfh
=vAlU
-----END PGP SIGNATURE-----



Reply to: