[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Patch for Tags.pm in sid



"Adam D. Barratt" <adam@adam-barratt.org.uk> writes:
> On Fri, 2009-07-31 at 14:56 -0700, Russ Allbery wrote:
>> "C.J. Adams-Collier" <cjac@colliertech.org> writes:

>>> --- /usr/share/lintian/lib/Tags.pm	2009-07-09 09:11:20.000000000 -0700
>>> +++ /tmp/Tags.pm	2009-07-31 14:17:49.000000000 -0700
>>> @@ -323,7 +323,7 @@
>>>      my $level;
>>>  
>>>      # Pedantic is just a pseudo severity, skip level checks
>>> -    if ($severity eq 'pedantic') {
>>> +    if ($severity && $severity eq 'pedantic') {
>>>  	$level = 1 ;
>>>      } elsif ($severity and $certainty) {
>>>  	$level = $display_level{$severity}{$certainty};

>> That would seem to indicate that we have a tag somewhere that doesn't
>> have a severity.  I'm not sure how else $serverity could end up being
>> undefined.

> Yeah, that was my immediate thought as well.  However, I can't find one
> - more to the point, neither can the test suite; scripts/tags.t already
> verifies that each tag has both severity and certainty and that their
> values are valid.

C.J., are you by any chance doing anything that may change what set of
checks Lintian is running, such as using add-on Lintian checks for
embdebian or dropping additional files into the checks directory?

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>


Reply to: