[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Patch for Tags.pm in sid

On Fri, 2009-07-31 at 22:05 +0100, Adam D. Barratt wrote:
> On Fri, 2009-07-31 at 13:13 -0700, C.J. Adams-Collier wrote:
> > Hey folks.  I keep getting perl module errors in sid.  Here's a patch
> > that fixes it.
> Thanks for taking the time to report this issue, and especially for
> providing a patch.

My pleasure.  Thank you for your prompt response.

> However, the code should never be producing the string "pædantic", nor
> can I find any occurrence of that string in the source tree.  We should
> be fixing whatever is causing that output, rather than patching around
> it.

True.  I should have mentioned that part of the patch was a joke.  I've
attached a clean version sans pædantic humor.

> Would it be possible to get some more details on exactly what you're
> doing when the error occurs, and how to reproduce it?

Of course.  During runs of debuild -uc -us, I was receiving many lines
of perl warnings that the $serverity variable was being used with the eq
operator when it was undefined.

> Thanks,
> Adam

My pleasure,

--- /usr/share/lintian/lib/Tags.pm	2009-07-09 09:11:20.000000000 -0700
+++ /tmp/Tags.pm	2009-07-31 14:17:49.000000000 -0700
@@ -323,7 +323,7 @@
     my $level;
     # Pedantic is just a pseudo severity, skip level checks
-    if ($severity eq 'pedantic') {
+    if ($severity && $severity eq 'pedantic') {
 	$level = 1 ;
     } elsif ($severity and $certainty) {
 	$level = $display_level{$severity}{$certainty};

Attachment: signature.asc
Description: This is a digitally signed message part

Reply to: