[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#533571: [checks/init.d] multiple corrections and enhancements



Raphael Geissert <atomo64@gmail.com> writes:

> I planned to send all my init.d-related changes together, but since
> I'm going to have a very busy weekend I might not finish the other
> checks I planned.  So, here it is what I've done so far:

Thanks, applied with some tweaks.

> commit e61537249dd53ef7195943bd84bad0ee416687e7
> Author: Raphael Geissert <atomo64@gmail.com>
> Date:   Tue Jun 16 15:07:40 2009 -0500
>
>     Don't treat /etc/init.d/README as an init script

/etc/init.d/skeleton should also be excluded since we don't want to
complain about not registering it.  Added.

> commit f9e8c4cd363e37d9754bf6c610996288b2f75aee
> Author: Raphael Geissert <atomo64@gmail.com>
> Date:   Sun Jun 14 21:12:19 2009 -0500
>
>     Check for init scripts with a /usr shebang

This is not a Policy violation and is not an RC bug, so it's not
severity: serious.  Init scripts are not randomly run before /usr is
mounted.  Only rcS scripts need worry about that now, and with
dependency boot systems, only scripts that don't declare a dependency on
the file system.  The point about the interpreter possibly being removed
is certainly valid, but /usr/bin/perl is essential.

I kept the check, since I think it's bad practice to write scripts in
something other than /bin/sh or /bin/bash or something similar, but I
made it normal/possible.  I think this one is a little questionable, and
I wonder if it shouldn't be checking for something else entirely or
excluding Perl or something.

It may be that it's rare enough there's no need to worry about it,
though.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>



Reply to: