[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#525280: [checks/cruft] Please increase date in outdated-autotools-helper-file check



Package: lintian
Severity: wishlist
Tags: Patch

Hi,

Currently the outdated-autotools-helper-file check checks for files prior
to 2004, but as mentioned here[0], the AVR32 architecture was only added
on 2006-06-06 and it would be helpful if the date this check uses could be
increased accordingly. I have attached a simple patch that does this.

I'm not sure if this wants to be kept as an error, since this will affect
a lot of packages only for the benefit of an in-progress unofficial arch
(I'm not sure about the kfreebsd situation with outdated files). Maybe
having an ancient (error) and old (warning) checks like the
Standards-Version check would be more suitable?

(Note: Checking for the day in the timestamp is not necessary since the
prior timestamp change was in May).

Regards,
Bradley Smith

[0] http://lists.debian.org/debian-devel/2009/04/msg00878.html

-- 
Bradley Smith                                     brad@brad-smith.co.uk
Debian GNU/Linux Developer                         bradsmith@debian.org
GPG: 0xC718D347       D201 7274 2FE1 A92A C45C EFAB 8F70 629A C718 D347
diff -Naur a/checks/cruft b/checks/cruft
--- a/checks/cruft	2009-04-03 19:49:11.000000000 +0100
+++ b/checks/cruft	2009-04-23 12:58:13.000000000 +0100
@@ -280,8 +280,9 @@
         open (F, '<', $b) or die "can't open $name: $!";
         while (<F>) {
             last if $. > 10; # it's on the 6th line, but be a bit more lenient
-            if (/^(?:timestamp|version)='(\d+)(.+)'$/ and $1 < 2004) {
-                tag "outdated-autotools-helper-file", $name, "$1$2";
+            if (/^(?:timestamp|version)='(\d+)-(\d+)(.*)'$/ and
+                ($1 < 2006 or ($1 == 2006 and $2 < 6))) {
+                tag "outdated-autotools-helper-file", $name, "$1-$2$3";
             }
         }
         close F;

Attachment: signature.asc
Description: PGP signature


Reply to: