Bug#512560: [lib/] some scripts use fail but don't use Util
On Wed, 2009-01-21 at 15:02 -0600, Raphael Geissert wrote:
> 2009/1/21 Adam D. Barratt <adam@adam-barratt.org.uk>:
> [...]
> >
> > I haven't applied the lib/Checker.pm change, because as far as I can see
> > Checker::register is never actually called. I've left the code in place
> > for the moment in case I've missed something.
>
> I did not check whether the functions calling fail where actually used
> or not, but what I know is that in the feature if it is used it
> will... "fail to fail" :)
>
> IMO the patch should be applied and then the code reviewed to find out
> whether that function should remain around.
In general, I agree. In this specific case, however, I'm not expecting
"for the moment" to last much longer than a day at most.
Adam
Reply to: