Re: [SCM] Debian package checker branch, master, updated. 1.24.4-117-g99615b2
On Sat, Sep 13, 2008 at 10:52:36AM +0100, Adam D. Barratt wrote:
> On Sat, 2008-09-13 at 09:49 +0000, Adam D. Barratt wrote:
> > diff --git a/lib/Lintian/Schedule.pm b/lib/Lintian/Schedule.pm
> > index 3c36363..a0d2dc6 100644
> > --- a/lib/Lintian/Schedule.pm
> > +++ b/lib/Lintian/Schedule.pm
> > @@ -47,6 +47,12 @@ sub add_file {
> > } else {
> > ($pkg, $ver, $arch) =
> > @pkg_info{qw(package version architecture)};
> > +
> > + if (!defined $arch) {
> > + $arch = $file;
> > + $arch =~ s/\.u?deb$//;
> > + $arch =~ s/.*_//;
> > + }
> > }
>
> This should possibly be another call to get_deb_info(), but that seemed
> a little overkill when we already had the rest of the information; more
> than happy to change it though.
Yeah, changing the list format is on my todo list together with changing
the archive format.
Anyway, the code can't stay that way because you do no error checking
that the filename is sane (which we should not require). If the missing arch
causes problems elsewhere, this should be fixed there.
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
Reply to: