Re: one more

[Frank Lichtenheld <djpig@debian.org>]

On Thu, Sep 11, 2008 at 08:58:56PM -0500, Raphael Geissert wrote:
> Frank Lichtenheld wrote:
> > On Thu, Sep 04, 2008 at 03:14:52PM -0500, Raphael Geissert wrote:
> >> Tag: maintainer-script-ignores-errors
> >> Type: warning
> >> Severity: normal
> >> Certainty: certain
> >> Ref: policy 3.9
> >> Info: The maintainer script doesn't seem to set the <tt>-e</tt> flag
> >> which
> >>  ensures that the script's execution is aborted when any executed command
> >> fails.
> > 
> > Hrm:
> > Running test on maintainer-scripts 7+dfsg-0.1: copying... building...
> > testing... FAILED:
> > --- testset/tags.maintainer-scripts   2008-08-30 00:51:10.000000000 +0200
> > +++ debian/tests/tags.maintainer-scripts      2008-09-12 00:39:44.000000000
> > +0200 @@ -50,6 +50,10 @@
> >  W: maintainer-scripts: maintainer-script-calls-deprecated-wm-menu-config
> >  postinst:33 W: maintainer-scripts: maintainer-script-empty config
> >  W: maintainer-scripts: maintainer-script-hides-init-failure postinst:57
> > +W: maintainer-scripts: maintainer-script-ignores-errors postinst
> > +W: maintainer-scripts: maintainer-script-ignores-errors postrm
> > +W: maintainer-scripts: maintainer-script-ignores-errors preinst
> > +W: maintainer-scripts: maintainer-script-ignores-errors prerm
> >  W: maintainer-scripts: maintainer-script-needs-depends-on-gconf2 postinst
> >  W: maintainer-scripts: maintainer-script-needs-depends-on-ucf postinst
> >  W: maintainer-scripts: maintainer-script-needs-depends-on-xml-core
> >  postinst
> > 
> > In the future please run the whole testsuite before submitting patches.
> 
> Right, sorry. Every new patch makes it take longer and longer to finish :-/

Yeah, I know. It's not like I run the full testsuite all the time.
All I asked was that you run it before sending a mail ;)

The way I usually work is that I run only a subset directly after a
commit and then run the full test suite in parallel while working on
the next patch, and once again before doing the push.

Gruesse,
-- 
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/